Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h" 5 #include "chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_obser ver.h"
6 #include "chrome/browser/browser_process.h" 6 #include "chrome/browser/browser_process.h"
7 #include "components/ukm/ukm_service.h" 7 #include "components/ukm/ukm_service.h"
8 #include "components/ukm/ukm_source.h" 8 #include "components/ukm/ukm_source.h"
9 9
10 // static 10 // static
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 void UkmPageLoadMetricsObserver::OnComplete( 44 void UkmPageLoadMetricsObserver::OnComplete(
45 const page_load_metrics::PageLoadTiming& timing, 45 const page_load_metrics::PageLoadTiming& timing,
46 const page_load_metrics::PageLoadExtraInfo& info) { 46 const page_load_metrics::PageLoadExtraInfo& info) {
47 SendMetricsToUkm(timing, info); 47 SendMetricsToUkm(timing, info);
48 } 48 }
49 49
50 void UkmPageLoadMetricsObserver::SendMetricsToUkm( 50 void UkmPageLoadMetricsObserver::SendMetricsToUkm(
51 const page_load_metrics::PageLoadTiming& timing, 51 const page_load_metrics::PageLoadTiming& timing,
52 const page_load_metrics::PageLoadExtraInfo& info) { 52 const page_load_metrics::PageLoadExtraInfo& info) {
53 if (info.committed_url.is_empty() || !timing.first_contentful_paint) 53 if (!info.did_commit || !timing.first_contentful_paint)
54 return; 54 return;
55 55
56 ukm::UkmService* ukm_service = g_browser_process->ukm_service(); 56 ukm::UkmService* ukm_service = g_browser_process->ukm_service();
57 DCHECK(ukm_service); 57 DCHECK(ukm_service);
58 58
59 std::unique_ptr<ukm::UkmSource> source = base::MakeUnique<ukm::UkmSource>(); 59 std::unique_ptr<ukm::UkmSource> source = base::MakeUnique<ukm::UkmSource>();
60 source->set_committed_url(info.committed_url); 60 source->set_committed_url(info.url);
61 source->set_first_contentful_paint(timing.first_contentful_paint.value()); 61 source->set_first_contentful_paint(timing.first_contentful_paint.value());
62 62
63 ukm_service->RecordSource(std::move(source)); 63 ukm_service->RecordSource(std::move(source));
64 } 64 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698