Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6446)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2692373003: Refactor PageLoadExtraInfo::committed_url to url and did_commit fields. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index 0f742d0ba12766f90aa839989a1d99848af50e9a..da26e0b453f9af5f9dde54fb6827b70c87de6948 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -111,8 +111,9 @@ struct PageLoadExtraInfo {
const base::Optional<base::TimeDelta>& first_foreground_time,
bool started_in_foreground,
UserInitiatedInfo user_initiated_info,
- const GURL& committed_url,
+ const GURL& url,
const GURL& start_url,
+ bool did_commit,
UserAbortType abort_type,
UserInitiatedInfo abort_user_initiated_info,
const base::Optional<base::TimeDelta>& time_to_abort,
@@ -134,13 +135,16 @@ struct PageLoadExtraInfo {
// Whether the page load was initiated by a user.
const UserInitiatedInfo user_initiated_info;
- // Committed URL. If the page load did not commit, |committed_url| will be
- // empty.
- const GURL committed_url;
+ // Most recent URL for this page. Can be updated at navigation start, upon
+ // redirection, and at commit time.
+ const GURL url;
// The URL that started the navigation, before redirects.
const GURL start_url;
+ // Whether the navigation for this page load committed.
+ const bool did_commit;
+
// The abort time and time to abort for this page load. If the page was not
// aborted, |abort_type| will be |ABORT_NONE|.
const UserAbortType abort_type;

Powered by Google App Engine
This is Rietveld 408576698