Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2692273010: Support animating <angle> custom properties (Closed)

Created:
3 years, 10 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support animating <angle> custom properties This patch adds support for animating custom properties registered with the <angle> syntax. The transition tests fail as transitions on registered custom properties are pending implementation. BUG=671904 Review-Url: https://codereview.chromium.org/2692273010 Cr-Commit-Position: refs/heads/master@{#451564} Committed: https://chromium.googlesource.com/chromium/src/+/3226260e934c3b0a58ea29c8caebe12a1910e862

Patch Set 1 #

Patch Set 2 : norebaseline #

Messages

Total messages: 14 (8 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-17 05:22:16 UTC) #2
Eric Willigers
Spec link?
3 years, 10 months ago (2017-02-17 05:41:04 UTC) #3
alancutter (OOO until 2018)
On 2017/02/17 at 05:41:04, ericwilligers wrote: > Spec link? Looks like it doesn't exist yet. ...
3 years, 10 months ago (2017-02-19 23:41:10 UTC) #4
Eric Willigers
lgtm
3 years, 10 months ago (2017-02-20 01:50:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692273010/20001
3 years, 10 months ago (2017-02-20 05:12:52 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 05:48:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3226260e934c3b0a58ea29c8caeb...

Powered by Google App Engine
This is Rietveld 408576698