Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2694103009: Support animating <time> custom properties (Closed)

Created:
3 years, 10 months ago by alancutter (OOO until 2018)
Modified:
3 years, 10 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support animating <time> custom properties This patch adds support for animating custom properties registered with the <time> syntax. The transition tests fail as transitions on registered custom properties are pending implementation. BUG=671904 Review-Url: https://codereview.chromium.org/2694103009 Cr-Commit-Position: refs/heads/master@{#451571} Committed: https://chromium.googlesource.com/chromium/src/+/de8e9a27e08f75e18fa76329498b5295c20ad53f

Patch Set 1 #

Patch Set 2 : Review changes #

Patch Set 3 : Undo git fail #

Messages

Total messages: 12 (8 generated)
alancutter (OOO until 2018)
3 years, 10 months ago (2017-02-17 05:37:38 UTC) #2
Eric Willigers
lgtm
3 years, 10 months ago (2017-02-20 01:52:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2694103009/40001
3 years, 10 months ago (2017-02-20 05:50:32 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 06:03:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/de8e9a27e08f75e18fa76329498b...

Powered by Google App Engine
This is Rietveld 408576698