Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2692203005: Remove unused context in ChromePreferenceManager. (Closed)

Created:
3 years, 10 months ago by Maria
Modified:
3 years, 10 months ago
Reviewers:
dgn
CC:
chromium-reviews, zpeng+watch_chromium.org, dominickn+watch_chromium.org, skanuj+watch_chromium.org, sadrul, samarth+watch_chromium.org, ntp-dev+reviews_chromium.org, donnd+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, melevin+watch_chromium.org, noyau+watch_chromium.org, twellington+watch_chromium.org, David Black, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, kalyank, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, pkotwicz+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused context in ChromePreferenceManager. Propagate the removed context change to other classes that were passing context only because they needed to pass it to the ChromePreferenceManager. BUG=691563 Review-Url: https://codereview.chromium.org/2692203005 Cr-Commit-Position: refs/heads/master@{#450886} Committed: https://chromium.googlesource.com/chromium/src/+/31b20b5b80ab095dafa26b198fd7208d6fef2be5

Patch Set 1 #

Patch Set 2 : Remove context from ContextualSearch classes #

Patch Set 3 : Fix a comment #

Patch Set 4 : Rebase and style check #

Patch Set 5 : Update new use #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -71 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/CtrSuppression.java View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapSuppressionHeuristics.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java View 1 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java View 1 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicyTest.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/MockContextualSearchPolicy.java View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 1 2 3 4 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/BottomSheetTestCaseBase.java View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Maria
3 years, 10 months ago (2017-02-15 00:56:50 UTC) #3
dgn
lgtm, thank you very much!
3 years, 10 months ago (2017-02-15 11:38:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692203005/60001
3 years, 10 months ago (2017-02-16 04:34:41 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/120262) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 10 months ago (2017-02-16 04:57:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2692203005/80001
3 years, 10 months ago (2017-02-16 05:19:24 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 07:19:53 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/31b20b5b80ab095dafa26b198fd7...

Powered by Google App Engine
This is Rietveld 408576698