chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java - Issue 2692203005: Remove unused context in ChromePreferenceManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

Issue 2692203005: Remove unused context in ChromePreferenceManager. (Closed)

Patch Set: Update new use Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/signin/SigninHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

index 8406e25f7bbfa6ae8745265144b8e31e0421db8f..a25b33b143afd65b4ecbd19cf19e4e2015600350 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoUtil.java

@@ -29,7 +29,7 @@ public class SigninPromoUtil {

// The promo is displayed if Chrome is launched directly (i.e., not with the intent to

// navigate to and view a URL on startup), the instance is part of the field trial,

// and the promo has been marked to display.

- ChromePreferenceManager preferenceManager = ChromePreferenceManager.getInstance(activity);

+ ChromePreferenceManager preferenceManager = ChromePreferenceManager.getInstance();

if (MultiWindowUtils.getInstance().isLegacyMultiWindow(activity)) return false;

if (!preferenceManager.getShowSigninPromo()) return false;

preferenceManager.setShowSigninPromo(false);