chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java - Issue 2692203005: Remove unused context in ChromePreferenceManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2692203005: Remove unused context in ChromePreferenceManager. (Closed)

Patch Set: Update new use Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

index 5639eb2fb9ee79b21535ada23d196c87430e5a1a..2cf4333c0a08fc37b919ff0d25cff2a9ccb592a7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

@@ -620,7 +620,7 @@ public class NewTabPageRecyclerView extends RecyclerView implements TouchDisable

if (computeVerticalScrollOffset() != 0) return;

// We only show the animation a certain number of times to a user.

- ChromePreferenceManager manager = ChromePreferenceManager.getInstance(getContext());

+ ChromePreferenceManager manager = ChromePreferenceManager.getInstance();

int animCount = manager.getNewTabPageFirstCardAnimationRunCount();

if (animCount > CardsVariationParameters.getFirstCardAnimationMaxRuns()) return;

manager.setNewTabPageFirstCardAnimationRunCount(animCount + 1);

@@ -645,7 +645,7 @@ public class NewTabPageRecyclerView extends RecyclerView implements TouchDisable

// for future runs.

if (!mFirstCardAnimationRun && !mCardImpressionAfterAnimationTracked) return;

- ChromePreferenceManager.getInstance(getContext()).setCardsImpressionAfterAnimation(true);

+ ChromePreferenceManager.getInstance().setCardsImpressionAfterAnimation(true);

mCardImpressionAfterAnimationTracked = true;

}