Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2691123003: [Script Spec Annotation] Annotate Steps 15--20 and 22 of "prepare a script" (Closed)

Created:
3 years, 10 months ago by hiroshige
Modified:
3 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Script Spec Annotation] Annotate Steps 15--20 and 22 of "prepare a script" BUG=686281 Review-Url: https://codereview.chromium.org/2691123003 Cr-Commit-Position: refs/heads/master@{#450277} Committed: https://chromium.googlesource.com/chromium/src/+/977fe146bd6777af01d8de34cbaab350b53d62f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 6 chunks +75 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
hiroshige
PTAL.
3 years, 10 months ago (2017-02-13 23:44:14 UTC) #3
kouhei (in TOK)
lgtm
3 years, 10 months ago (2017-02-14 01:28:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2691123003/1
3 years, 10 months ago (2017-02-14 04:37:37 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 06:16:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/977fe146bd6777af01d8de34cbaa...

Powered by Google App Engine
This is Rietveld 408576698