Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 2690273002: [Script Spec Annotation] Annotate "prepare a script" (Closed)

Created:
3 years, 10 months ago by hiroshige
Modified:
3 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Script Spec Annotation] Annotate "prepare a script" https://html.spec.whatwg.org/#prepare-a-script BUG=686281 Review-Url: https://codereview.chromium.org/2690273002 Cr-Commit-Position: refs/heads/master@{#450240} Committed: https://chromium.googlesource.com/chromium/src/+/d07584db64b31ca46f90b54b8cb65948d6dbc768

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -22 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 6 chunks +172 lines, -22 lines 1 comment Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 5 chunks +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
hiroshige
https://codereview.chromium.org/2690273002/diff/20001/third_party/WebKit/Source/core/dom/ScriptLoader.cpp File third_party/WebKit/Source/core/dom/ScriptLoader.cpp (right): https://codereview.chromium.org/2690273002/diff/20001/third_party/WebKit/Source/core/dom/ScriptLoader.cpp#newcode361 third_party/WebKit/Source/core/dom/ScriptLoader.cpp:361: return true; I replaced if-then-else-if-else-if-... block with if(...){return true;} ...
3 years, 10 months ago (2017-02-13 22:59:54 UTC) #7
kouhei (in TOK)
amazing! lgtm
3 years, 10 months ago (2017-02-13 23:04:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690273002/20001
3 years, 10 months ago (2017-02-14 04:10:21 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 04:17:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d07584db64b31ca46f90b54b8cb6...

Powered by Google App Engine
This is Rietveld 408576698