DCHECK: load event is dispatched after executeScript() iff m_isExternalScript

DCHECK: load event is dispatched after executeScript() iff m_isExternalScript

Currently, ScriptLoader::executeScript() mostly corresponds to
"execute a script block" in the spec.
https://html.spec.whatwg.org/#execute-the-script-block
However, its Steps 2 and 8 (dispatching error and load events,
respectively) are handled in the caller of executeScript().

As a preparation for moving the code for Steps 2 and 8 into
executeScript(), this CL adds DCHECK()s that confirms all the callers
of executeScript() dispatches a load event if and only if the script
is from an external file, as the spec says.

BUG=686281

[hiroshige, 2017-02-14 01:35:18]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 01:36:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-02-14 01:38:52]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 01:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-02-14 01:41:43]

Description was changed from

==========
DCHECK: load event is dispatched after executeScript() iff m_isExternalScript

BUG=
==========

to

==========
DCHECK: load event is dispatched after executeScript() iff m_isExternalScript

Currently, ScriptLoader::executeScript() mostly corresponds to
"execute a script block" in the spec.
https://html.spec.whatwg.org/#execute-the-script-block
However, its Steps 2 and 8 (dispatching error and load events,
respectively) are handled in the caller of executeScript().

As a preparation for moving the code for Steps 2 and 8 into
executeScript(), this CL adds DCHECK()s that confirms all the callers
of executeScript() dispatches a load event if and only if the script
is from an external file, as the spec says.

BUG=686281
==========

[hiroshige, 2017-02-14 01:41:43]

hiroshige@chromium.org changed reviewers:
+ kouhei@chromium.org

[hiroshige, 2017-02-14 01:42:21]

PTAL.

(I expect the actual refactoring will be after ES6 module implementation though)

[kouhei (in TOK), 2017-02-14 01:50:54]

https://codereview.chromium.org/2694943002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/ScriptLoader.h (right):

https://codereview.chromium.org/2694943002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/ScriptLoader.h:121: #if DCHECK_IS_ON()
Can we remove #if here? as m_isExternalScript exists regardless of this clause,
I think we can always have this predicate.

[kouhei (in TOK), 2017-02-14 01:51:01]

lgtm

[commit-bot: I haz the power, 2017-02-14 03:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 03:19:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2017-02-23 02:06:37]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 02:07:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-02-23 02:07:24]

On 2017/02/14 01:51:01, kouhei wrote:
> lgtm

Assertion fails :(
I'll investigate why later.

[commit-bot: I haz the power, 2017-02-23 03:25:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 03:25:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)