Remove obsolete code in TabModelOrderController.

Remove obsolete code in TabModelOrderController.

The insertion direction in TabModelOrderController could be
controlled by insertionPolicy property however it was never
set to another value after initialisation, thus becoming a
constant.

Remove the enumeration, the property and inline the value in
the different location it was used, removing the alternatives
that are now unreachable.

Refactor -insertionIndexForTab:transition:opener:adjacency
to use early exit instead of using nested if blocks. Remove
obsolete method -firstTabWithOpener: from TabModel.

Modernize the TabModelOrderController API (move the ivar to
the implementation file, init returns instancetype, convert
the file to ARC).

BUG=687207
Review-Url: https://codereview.chromium.org/2690893003
Cr-Commit-Position: refs/heads/master@{#450709}
Committed: https://chromium.googlesource.com/chromium/src/+/bf571dff95b062353eacd029bbf7cb545549601a

[sdefresne, 2017-02-13 17:27:26]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-02-13 17:27:35]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-02-13 17:27:35]

Please take a look.

[commit-bot: I haz the power, 2017-02-13 17:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 17:30:24]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rohitrao (ping after 24h), 2017-02-13 19:54:12]

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model_order_controller.mm (right):

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_order_controller.mm:14: __weak TabModel*
model_;  // weak, owns us
Presumably this comment is unnecessary now?

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_order_controller.mm:39: Tab* openLocation =
openLocation = [model_ lastTabWithOpener:parentTab];
Remove "= openLocation"?

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_order_controller.mm:43: if (openLocation)
Should this be !openLocation?

[rohitrao (ping after 24h), 2017-02-13 19:54:51]

The CL description should also perhaps mention the various code modernization
changes.

[sdefresne, 2017-02-14 10:20:25]

Description was changed from

==========
Remove obsolete code in TabModelOrderController.

The insertion direction in TabModelOrderController could be
controlled by insertionPolicy property however it was never
set to another value after initialisation, thus becoming a
constant.

Remove the enumeration, the property and inline the value in
the different location it was used, removing the alternatives
that are now unreachable.

Refactor -insertionIndexForTab:transition:opener:adjacency
to use early exit instead of using nested if blocks. Remove
obsolete method -firstTabWithOpener: from TabModel.

BUG=687207
==========

to

==========
Remove obsolete code in TabModelOrderController.

The insertion direction in TabModelOrderController could be
controlled by insertionPolicy property however it was never
set to another value after initialisation, thus becoming a
constant.

Remove the enumeration, the property and inline the value in
the different location it was used, removing the alternatives
that are now unreachable.

Refactor -insertionIndexForTab:transition:opener:adjacency
to use early exit instead of using nested if blocks. Remove
obsolete method -firstTabWithOpener: from TabModel.

Modernize the TabModelOrderController API (move the ivar
to the implementation file, init returns instancetype, convert
the file to ARC).

BUG=687207
==========

[sdefresne, 2017-02-14 10:20:41]

Description was changed from

==========
Remove obsolete code in TabModelOrderController.

The insertion direction in TabModelOrderController could be
controlled by insertionPolicy property however it was never
set to another value after initialisation, thus becoming a
constant.

Remove the enumeration, the property and inline the value in
the different location it was used, removing the alternatives
that are now unreachable.

Refactor -insertionIndexForTab:transition:opener:adjacency
to use early exit instead of using nested if blocks. Remove
obsolete method -firstTabWithOpener: from TabModel.

Modernize the TabModelOrderController API (move the ivar
to the implementation file, init returns instancetype, convert
the file to ARC).

BUG=687207
==========

to

==========
Remove obsolete code in TabModelOrderController.

The insertion direction in TabModelOrderController could be
controlled by insertionPolicy property however it was never
set to another value after initialisation, thus becoming a
constant.

Remove the enumeration, the property and inline the value in
the different location it was used, removing the alternatives
that are now unreachable.

Refactor -insertionIndexForTab:transition:opener:adjacency
to use early exit instead of using nested if blocks. Remove
obsolete method -firstTabWithOpener: from TabModel.

Modernize the TabModelOrderController API (move the ivar to
the implementation file, init returns instancetype, convert
the file to ARC).

BUG=687207
==========

[sdefresne, 2017-02-14 16:15:29]

PTAL.

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
File ios/chrome/browser/tabs/tab_model_order_controller.mm (right):

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_order_controller.mm:14: __weak TabModel*
model_;  // weak, owns us
On 2017/02/13 19:54:12, rohitrao wrote:
> Presumably this comment is unnecessary now?

Done.

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_order_controller.mm:39: Tab* openLocation =
openLocation = [model_ lastTabWithOpener:parentTab];
On 2017/02/13 19:54:12, rohitrao wrote:
> Remove "= openLocation"?

Done.

https://codereview.chromium.org/2690893003/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab_model_order_controller.mm:43: if (openLocation)
On 2017/02/13 19:54:12, rohitrao wrote:
> Should this be !openLocation?

Good catch. My code was incorrect and I've fixed it.

[rohitrao (ping after 24h), 2017-02-14 16:27:54]

lgtm

https://codereview.chromium.org/2690893003/diff/20001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2690893003/diff/20001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab_model.mm:287: DCHECK_GT(_webStateList.count(), 0);
DCHECK_GE?  0 should be a valid count.

[sdefresne, 2017-02-14 16:44:36]

https://codereview.chromium.org/2690893003/diff/20001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2690893003/diff/20001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab_model.mm:287: DCHECK_GT(_webStateList.count(), 0);
On 2017/02/14 16:27:53, rohitrao wrote:
> DCHECK_GE?  0 should be a valid count.

Good catch, fixed in dependent CL.

[sdefresne, 2017-02-14 16:47:51]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 16:48:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 16:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 16:57:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2017-02-15 14:45:22]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 14:45:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-02-15 14:46:06]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2017-02-15 15:08:14]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-02-15 15:08:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2690893003/#ps60001
(title: "Rebase on origin/master.")

[commit-bot: I haz the power, 2017-02-15 15:08:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 15:44:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487171294620380,
"parent_rev": "74635441b51ea815077a446193f68d6ac0dd3f30", "commit_rev":
"bf571dff95b062353eacd029bbf7cb545549601a"}

[commit-bot: I haz the power, 2017-02-15 15:44:51]

Description was changed from

==========
Remove obsolete code in TabModelOrderController.

The insertion direction in TabModelOrderController could be
controlled by insertionPolicy property however it was never
set to another value after initialisation, thus becoming a
constant.

Remove the enumeration, the property and inline the value in
the different location it was used, removing the alternatives
that are now unreachable.

Refactor -insertionIndexForTab:transition:opener:adjacency
to use early exit instead of using nested if blocks. Remove
obsolete method -firstTabWithOpener: from TabModel.

Modernize the TabModelOrderController API (move the ivar to
the implementation file, init returns instancetype, convert
the file to ARC).

BUG=687207
==========

to

==========
Remove obsolete code in TabModelOrderController.

The insertion direction in TabModelOrderController could be
controlled by insertionPolicy property however it was never
set to another value after initialisation, thus becoming a
constant.

Remove the enumeration, the property and inline the value in
the different location it was used, removing the alternatives
that are now unreachable.

Refactor -insertionIndexForTab:transition:opener:adjacency
to use early exit instead of using nested if blocks. Remove
obsolete method -firstTabWithOpener: from TabModel.

Modernize the TabModelOrderController API (move the ivar to
the implementation file, init returns instancetype, convert
the file to ARC).

BUG=687207

Review-Url: https://codereview.chromium.org/2690893003
Cr-Commit-Position: refs/heads/master@{#450709}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf571dff95b062353eacd029bbf7...
==========

[commit-bot: I haz the power, 2017-02-15 15:44:52]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bf571dff95b062353eacd029bbf7...