Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2690893003: Remove obsolete code in TabModelOrderController. (Closed)
Patch Set: Rebase on origin/master. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_order_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index bb29e05d124932ae0cf853325852b0a3055c13c9..c28266e9305f38fa2675ecc07fa7be60dd8bd7b1 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -456,7 +456,6 @@ TEST_F(TabModelTest, OpenersEmptyModel) {
EXPECT_TRUE([tab_model_ isEmpty]);
EXPECT_FALSE([tab_model_ nextTabWithOpener:nil afterTab:nil]);
EXPECT_FALSE([tab_model_ lastTabWithOpener:nil]);
- EXPECT_FALSE([tab_model_ firstTabWithOpener:nil]);
}
TEST_F(TabModelTest, OpenersNothingOpenedGeneral) {
@@ -473,14 +472,12 @@ TEST_F(TabModelTest, OpenersNothingOpenedGeneral) {
// All should fail since this hasn't opened anything else.
EXPECT_FALSE([tab_model_ nextTabWithOpener:tab afterTab:nil]);
EXPECT_FALSE([tab_model_ lastTabWithOpener:tab]);
- EXPECT_FALSE([tab_model_ firstTabWithOpener:tab]);
// Add more items to the tab, expect the same results.
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer windowName:nil];
EXPECT_FALSE([tab_model_ nextTabWithOpener:tab afterTab:nil]);
EXPECT_FALSE([tab_model_ lastTabWithOpener:tab]);
- EXPECT_FALSE([tab_model_ firstTabWithOpener:tab]);
}
TEST_F(TabModelTest, OpenersNothingOpenedFirst) {
@@ -494,7 +491,6 @@ TEST_F(TabModelTest, OpenersNothingOpenedFirst) {
// All should fail since this hasn't opened anything else.
EXPECT_FALSE([tab_model_ nextTabWithOpener:tab afterTab:nil]);
EXPECT_FALSE([tab_model_ lastTabWithOpener:tab]);
- EXPECT_FALSE([tab_model_ firstTabWithOpener:tab]);
}
TEST_F(TabModelTest, OpenersNothingOpenedLast) {
@@ -507,16 +503,13 @@ TEST_F(TabModelTest, OpenersNothingOpenedLast) {
// All should fail since this hasn't opened anything else.
EXPECT_FALSE([tab_model_ nextTabWithOpener:tab afterTab:nil]);
EXPECT_FALSE([tab_model_ lastTabWithOpener:tab]);
- EXPECT_FALSE([tab_model_ firstTabWithOpener:tab]);
}
TEST_F(TabModelTest, OpenersChildTabBeforeOpener) {
Tab* parent_tab = [tab_model_ insertTabWithWebState:CreateWebState(@"window")
atIndex:[tab_model_ count]];
// Insert child at start
- Tab* child_tab =
- [tab_model_ insertTabWithWebState:CreateChildWebState(parent_tab)
- atIndex:0];
+ [tab_model_ insertTabWithWebState:CreateChildWebState(parent_tab) atIndex:0];
// Insert a few more between them.
[tab_model_ insertTabWithWebState:CreateWebState(@"window") atIndex:1];
@@ -524,7 +517,6 @@ TEST_F(TabModelTest, OpenersChildTabBeforeOpener) {
EXPECT_FALSE([tab_model_ nextTabWithOpener:parent_tab afterTab:nil]);
EXPECT_FALSE([tab_model_ lastTabWithOpener:parent_tab]);
- EXPECT_EQ([tab_model_ firstTabWithOpener:parent_tab], child_tab);
}
TEST_F(TabModelTest, OpenersChildTabAfterOpener) {
@@ -545,7 +537,6 @@ TEST_F(TabModelTest, OpenersChildTabAfterOpener) {
EXPECT_EQ([tab_model_ nextTabWithOpener:parent_tab afterTab:child_tab1],
child_tab2);
EXPECT_EQ([tab_model_ lastTabWithOpener:parent_tab], child_tab2);
- EXPECT_FALSE([tab_model_ firstTabWithOpener:parent_tab]);
}
TEST_F(TabModelTest, AddWithOrderController) {
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_order_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698