Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: ios/chrome/browser/tabs/tab_model_order_controller.h

Issue 2690893003: Remove obsolete code in TabModelOrderController. (Closed)
Patch Set: Rebase on origin/master. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/tabs/tab_model_order_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_order_controller.h
diff --git a/ios/chrome/browser/tabs/tab_model_order_controller.h b/ios/chrome/browser/tabs/tab_model_order_controller.h
index 2fec1f2b0005fbc8cd7f992fed2ddade4f7db8bf..d3e38058e97f3328fe20710d12b1eec7d44714cc 100644
--- a/ios/chrome/browser/tabs/tab_model_order_controller.h
+++ b/ios/chrome/browser/tabs/tab_model_order_controller.h
@@ -12,14 +12,6 @@
namespace TabModelOrderConstants {
-// InsertionPolicy is a general policy for opening all new tabs.
-enum InsertionPolicy {
- // Newly created tabs are created after the selection. This is the default.
- kInsertAfter,
- // Newly created tabs are inserted before the selection.
- kInsertBefore,
-};
-
// InsertionAdjacency allows different links to choose to open tabs directly
// before or after a given tab, depending on context.
enum InsertionAdjacency {
@@ -35,18 +27,10 @@ enum InsertionAdjacency {
// heuristics plugged into a TabStripModel. Closely parallels
// chrome/browser/tabs/tab_strip_model_order_controller.h
// but without the dependence on TabContentsWrapper and TabStripModel.
-@interface TabModelOrderController : NSObject {
- @private
- TabModel* model_; // weak, owns us
- TabModelOrderConstants::InsertionPolicy insertionPolicy_;
-}
-
-// Sets the insertion policy for new tabs. Default is |kInsertAfter|.
-@property(nonatomic, assign)
- TabModelOrderConstants::InsertionPolicy insertionPolicy;
+@interface TabModelOrderController : NSObject
// Initializer, |model| must be non-nil and is not retained.
-- (id)initWithTabModel:(TabModel*)model;
+- (instancetype)initWithTabModel:(TabModel*)model;
// Determines where to place a newly opened tab by using the transition and
// adjacency flags.
@@ -56,7 +40,7 @@ enum InsertionAdjacency {
adjacency:(TabModelOrderConstants::InsertionAdjacency)
adjacency;
-// Returns the index at which to append tabs, based on |insertionPolicy|.
+// Returns the index at which to append tabs.
- (NSUInteger)insertionIndexForAppending;
// Returns the tab in which to shift selection after a tab is closed. May
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/tabs/tab_model_order_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698