Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2690633002: Fix PaintLayer::compositingContainer for self-painting non-stacked layers (Closed)

Created:
3 years, 10 months ago by Xianzhu
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix PaintLayer::compositingContainer for self-painting non-stacked layers A self-painting non-stacked layer always paint itself through the normal flow list of its parent, no matter if the parent is the containing layer. This affects float layer under a stacked inline layer. If the float layer is self-painting but not stacked, it's painted from its parent instead of its containing layer. BUG=686481 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2682933002 Cr-Original-Commit-Position: refs/heads/master@{#449219} Review-Url: https://codereview.chromium.org/2690633002 Cr-Commit-Position: refs/branch-heads/2987@{#449} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/5ffefa7a3d0b13b25f70f436ac4b92c8d193e541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/column-float-under-stacked-inline.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/column-float-under-stacked-inline-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690633002/1
3 years, 10 months ago (2017-02-10 19:58:18 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 20:04:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ffefa7a3d0b13b25f70f436ac4b...

Powered by Google App Engine
This is Rietveld 408576698