third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 2690633002: Fix PaintLayer::compositingContainer for self-painting non-stacked layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2690633002: Fix PaintLayer::compositingContainer for self-painting non-stacked layers (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index ee4134b4d4d964e2ab6b5a96fa981fe833415473..d1f22d16775b05973b33e562f0f1507c2e91f5d6 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -921,7 +921,8 @@ PaintLayer* PaintLayer::compositingContainer() const {

if (!stackingNode()->isStacked()) {

// Floats have special painting order, which has complicated semantics.

// See the comments around FloatObject::setShouldPaint.

- if (m_layoutObject->isFloating() && m_layoutObject->parent() &&

+ if (!isSelfPaintingLayer() && m_layoutObject->isFloating() &&

+ m_layoutObject->parent() &&

!m_layoutObject->parent()->isLayoutBlockFlow())

return m_layoutObject->containingBlock()->enclosingLayer();