Fix PaintLayer::compositingContainer for self-painting non-stacked layers

Fix PaintLayer::compositingContainer for self-painting non-stacked layers

A self-painting non-stacked layer always paint itself through the normal
flow list of its parent, no matter if the parent is the containing layer.
This affects float layer under a stacked inline layer. If the float
layer is self-painting but not stacked, it's painted from its parent
instead of its containing layer.

BUG=686481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2682933002
Cr-Commit-Position: refs/heads/master@{#449219}
Committed: https://chromium.googlesource.com/chromium/src/+/bfa6918b9aaf67f812459e5757e46485ff8ae1d4

[Xianzhu, 2017-02-08 06:26:15]

Description was changed from

==========
Fix PaintLayer::compositingContainer for self-painting non-stacked layers

A self-painting non-stacked layer always paint itself through the normal
flow list of its parent, no matter if the parent is the containing layer.
This affects float layer under a stacked inline layer. If the float
layer is self-painting but not stacked, it's painted from its parent
instead of its containing layer.

BUG=686481
==========

to

==========
Fix PaintLayer::compositingContainer for self-painting non-stacked layers

A self-painting non-stacked layer always paint itself through the normal
flow list of its parent, no matter if the parent is the containing layer.
This affects float layer under a stacked inline layer. If the float
layer is self-painting but not stacked, it's painted from its parent
instead of its containing layer.

BUG=686481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-02-08 06:26:25]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 06:26:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 07:44:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 07:44:56]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2017-02-08 15:49:27]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2017-02-08 16:56:20]

lgtm

https://codereview.chromium.org/2682933002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerTest.cpp (right):

https://codereview.chromium.org/2682933002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerTest.cpp:670: "    <div
id='target' style='columns: 1; float: left'></div>"
Add a comment that this is testing a non-stacked, self-painting
layer.

[chrishtr, 2017-02-08 16:56:36]

could you cc me on crbug.com/686481?

[Xianzhu, 2017-02-09 01:21:55]

https://codereview.chromium.org/2682933002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintLayerTest.cpp (right):

https://codereview.chromium.org/2682933002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintLayerTest.cpp:670: "    <div
id='target' style='columns: 1; float: left'></div>"
On 2017/02/08 16:56:20, chrishtr wrote:
> Add a comment that this is testing a non-stacked, self-painting
> layer.

Done.

[Xianzhu, 2017-02-09 01:22:00]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-02-09 01:22:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2682933002/#ps20001
(title: "Fix PaintLayer::compositingContainer for self-painting non-stacked
layers")

[commit-bot: I haz the power, 2017-02-09 01:22:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 06:12:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486603320423390,
"parent_rev": "9539388cc0c6c98a76e2a3f946dba1efaf13bfdc", "commit_rev":
"bfa6918b9aaf67f812459e5757e46485ff8ae1d4"}

[commit-bot: I haz the power, 2017-02-09 06:13:21]

Description was changed from

==========
Fix PaintLayer::compositingContainer for self-painting non-stacked layers

A self-painting non-stacked layer always paint itself through the normal
flow list of its parent, no matter if the parent is the containing layer.
This affects float layer under a stacked inline layer. If the float
layer is self-painting but not stacked, it's painted from its parent
instead of its containing layer.

BUG=686481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix PaintLayer::compositingContainer for self-painting non-stacked layers

A self-painting non-stacked layer always paint itself through the normal
flow list of its parent, no matter if the parent is the containing layer.
This affects float layer under a stacked inline layer. If the float
layer is self-painting but not stacked, it's painted from its parent
instead of its containing layer.

BUG=686481
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2682933002
Cr-Commit-Position: refs/heads/master@{#449219}
Committed:
https://chromium.googlesource.com/chromium/src/+/bfa6918b9aaf67f812459e5757e4...
==========

[commit-bot: I haz the power, 2017-02-09 06:13:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bfa6918b9aaf67f812459e5757e4...