Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2690343003: [WPT Export] Fix omitted self in run_command argument (Closed)

Created:
3 years, 10 months ago by jeffcarp
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WPT Export] Fix omitted self in run_command argument BUG=689118 Review-Url: https://codereview.chromium.org/2690343003 Cr-Commit-Position: refs/heads/master@{#450628} Committed: https://chromium.googlesource.com/chromium/src/+/bcee4ae4d62ead9b398ee9f5afdf511fbb723962

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move ChromiumCommit.absolute_chromium_dir assignment up to make tests pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py View 1 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jeffcarp
3 years, 10 months ago (2017-02-14 23:43:09 UTC) #2
qyearsley
lgtm https://codereview.chromium.org/2690343003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py (right): https://codereview.chromium.org/2690343003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py#newcode38 third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py:38: self.absolute_chromium_wpt_dir = absolute_chromium_wpt_dir(host) Didn't mention it before, but ...
3 years, 10 months ago (2017-02-14 23:45:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690343003/1
3 years, 10 months ago (2017-02-15 03:53:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/388644)
3 years, 10 months ago (2017-02-15 05:13:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690343003/20001
3 years, 10 months ago (2017-02-15 05:24:46 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 07:44:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bcee4ae4d62ead9b398ee9f5afdf...

Powered by Google App Engine
This is Rietveld 408576698