Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py

Issue 2690343003: [WPT Export] Fix omitted self in run_command argument (Closed)
Patch Set: Move ChromiumCommit.absolute_chromium_dir assignment up to make tests pass Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
index aba91013342e136ff5a849d1f27e6ac23b4cccdd..efc1e5722d1257d1f9d12bb4835057713cd62050 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py
@@ -20,6 +20,8 @@ class ChromiumCommit(object):
'refs/heads/master@{#431915}'
"""
self.host = host
+ self.absolute_chromium_dir = absolute_chromium_dir(host)
+ self.absolute_chromium_wpt_dir = absolute_chromium_wpt_dir(host)
assert sha or position, 'requires sha or position'
assert not (sha and position), 'cannot accept both sha and position'
@@ -34,9 +36,6 @@ class ChromiumCommit(object):
self.sha = sha
self.position = position
- self.absolute_chromium_dir = absolute_chromium_dir(host)
- self.absolute_chromium_wpt_dir = absolute_chromium_wpt_dir(host)
-
def num_behind_master(self):
"""Returns the number of commits this commit is behind origin/master.
It is inclusive of this commit and of the latest commit.
@@ -48,7 +47,7 @@ class ChromiumCommit(object):
def position_to_sha(self, commit_position):
return self.host.executive.run_command([
'git', 'crrev-parse', commit_position
- ], cwd=absolute_chromium_dir).strip()
+ ], cwd=self.absolute_chromium_dir).strip()
def subject(self):
return self.host.executive.run_command([
@@ -58,7 +57,7 @@ class ChromiumCommit(object):
def body(self):
return self.host.executive.run_command([
'git', 'show', '--format=%b', '--no-patch', self.sha
- ], cwd=absolute_chromium_dir)
+ ], cwd=self.absolute_chromium_dir)
def author(self):
return self.host.executive.run_command([
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698