[WPT Export] Fix omitted self in run_command argument

third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from webkitpy.w3c.chromium_finder import absolute_chromium_dir, absolute_chromium_wpt_dir
 
 CHROMIUM_WPT_DIR = 'third_party/WebKit/LayoutTests/external/wpt/'
 
 
 class ChromiumCommit(object):
@@ skipping 17 matching lines @@
             if position.startswith('Cr-Commit-Position: '):
                 position = position[len('Cr-Commit-Position: '):]
 
             sha = self.position_to_sha(position)
 
         assert len(sha) == 40, 'Expected SHA-1 hash, got {}'.format(sha)
         self.sha = sha
         self.position = position
 
         self.absolute_chromium_dir = absolute_chromium_dir(host)
         self.absolute_chromium_wpt_dir = absolute_chromium_wpt_dir(host)

[qyearsley, 2017/02/14 23:45:32]

Didn't mention it before, but these could also optionally be marked as
protected/private with underscore prefix; this is fine too though.

 
     def num_behind_master(self):
         """Returns the number of commits this commit is behind origin/master.
         It is inclusive of this commit and of the latest commit.
         """
         return len(self.host.executive.run_command([
             'git', 'rev-list', '{}..origin/master'.format(self.sha)
         ], cwd=self.absolute_chromium_dir).splitlines())
 
     def position_to_sha(self, commit_position):
         return self.host.executive.run_command([
             'git', 'crrev-parse', commit_position
-        ], cwd=absolute_chromium_dir).strip()
+        ], cwd=self.absolute_chromium_dir).strip()
 
     def subject(self):
         return self.host.executive.run_command([
             'git', 'show', '--format=%s', '--no-patch', self.sha
         ], cwd=self.absolute_chromium_dir)
 
     def body(self):
         return self.host.executive.run_command([
             'git', 'show', '--format=%b', '--no-patch', self.sha
-        ], cwd=absolute_chromium_dir)
+        ], cwd=self.absolute_chromium_dir)
 
     def author(self):
         return self.host.executive.run_command([
             'git', 'show', '--format="%aN <%aE>"', '--no-patch', self.sha
         ], cwd=self.absolute_chromium_dir)
 
     def message(self):
         """Returns a string with a commit's subject and body."""
         return self.host.executive.run_command([
             'git', 'show', '--format=%B', '--no-patch', self.sha
@@ skipping 22 matching lines @@
     def format_patch(self):
         """Makes a patch with only exportable changes."""
         filtered_files = self.filtered_changed_files()
 
         if not filtered_files:
             return ''
 
         return self.host.executive.run_command([
             'git', 'format-patch', '-1', '--stdout', self.sha, '--'
         ] + filtered_files, cwd=self.absolute_chromium_dir)