Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2690333005: [WPT Export] Fix remaining Git working directory bugs (Closed)

Created:
3 years, 10 months ago by jeffcarp
Modified:
3 years, 10 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WPT Export] Fix remaining Git working directory bugs BUG=689118 Review-Url: https://codereview.chromium.org/2690333005 Cr-Commit-Position: refs/heads/master@{#450503} Committed: https://chromium.googlesource.com/chromium/src/+/da91743976059b2cddbb17fe744f5898f2d45f0b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py View 3 chunks +13 lines, -21 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py View 1 chunk +18 lines, -0 lines 1 comment Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jeffcarp
3 years, 10 months ago (2017-02-14 21:06:31 UTC) #2
jeffcarp
https://codereview.chromium.org/2690333005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py (right): https://codereview.chromium.org/2690333005/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py#newcode18 third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py:18: return finder.chromium_base() I needed to create this file to ...
3 years, 10 months ago (2017-02-14 21:07:26 UTC) #3
qyearsley
LGTM to commit -- IMO, I think what would make sense to me for future ...
3 years, 10 months ago (2017-02-14 21:19:48 UTC) #4
jeffcarp
On 2017/02/14 at 21:19:48, qyearsley wrote: > LGTM to commit -- > > IMO, I ...
3 years, 10 months ago (2017-02-14 21:56:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690333005/1
3 years, 10 months ago (2017-02-14 21:57:28 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 23:08:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da91743976059b2cddbb17fe744f...

Powered by Google App Engine
This is Rietveld 408576698