[WPT Export] Fix remaining Git working directory bugs

[WPT Export] Fix remaining Git working directory bugs

BUG=689118
Review-Url: https://codereview.chromium.org/2690333005
Cr-Commit-Position: refs/heads/master@{#450503}
Committed: https://chromium.googlesource.com/chromium/src/+/da91743976059b2cddbb17fe744f5898f2d45f0b

[jeffcarp, 2017-02-14 21:06:31]

jeffcarp@chromium.org changed reviewers:
+ qyearsley@chromium.org

[jeffcarp, 2017-02-14 21:07:26]

https://codereview.chromium.org/2690333005/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py (right):

https://codereview.chromium.org/2690333005/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py:18: return
finder.chromium_base()
I needed to create this file to avoid a cyclical dependency between
ChromiumCommit and Common, but lmk if there's a better way. I also considered
just inlining the ChromiumCommit class into the common file.

[qyearsley, 2017-02-14 21:19:48]

LGTM to commit --

IMO, I think what would make sense to me for future changes is:

 - Most of the methods in ChromiumCommit should actually go in Git, e.g.
   position_to_sha, subject, message, author, etc.
 - ChromiumCommit could be a super simple class with very few methods, maybe
just a container for a position and SHA and other related info which could be
obtained using logic elsewhere (e.g. from a Git instance). And ChromiumCommit
could go into common, along with helper functions like
absolute_chromium_wpt_dir.

What do you think?

[jeffcarp, 2017-02-14 21:56:25]

On 2017/02/14 at 21:19:48, qyearsley wrote:
> LGTM to commit --
> 
> IMO, I think what would make sense to me for future changes is:
> 
>  - Most of the methods in ChromiumCommit should actually go in Git, e.g.
>    position_to_sha, subject, message, author, etc.
>  - ChromiumCommit could be a super simple class with very few methods, maybe
just a container for a position and SHA and other related info which could be
obtained using logic elsewhere (e.g. from a Git instance). And ChromiumCommit
could go into common, along with helper functions like
absolute_chromium_wpt_dir.
> 
> What do you think?

That sounds good! There's a bug for using Git here:
https://bugs.chromium.org/p/chromium/issues/detail?id=676399

I'll add to the bug that we want to fold most ChromiumCommit methods into Git.

[jeffcarp, 2017-02-14 21:56:58]

The CQ bit was checked by jeffcarp@chromium.org

[commit-bot: I haz the power, 2017-02-14 21:57:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:07:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487109418780890, "parent_rev":
"877232051110caf21cfed300371fdadf7cea6ffe", "commit_rev":
"da91743976059b2cddbb17fe744f5898f2d45f0b"}

[commit-bot: I haz the power, 2017-02-14 23:08:12]

Description was changed from

==========
[WPT Export] Fix remaining Git working directory bugs

BUG=689118
==========

to

==========
[WPT Export] Fix remaining Git working directory bugs

BUG=689118

Review-Url: https://codereview.chromium.org/2690333005
Cr-Commit-Position: refs/heads/master@{#450503}
Committed:
https://chromium.googlesource.com/chromium/src/+/da91743976059b2cddbb17fe744f...
==========

[commit-bot: I haz the power, 2017-02-14 23:08:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da91743976059b2cddbb17fe744f...