third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py - Issue 2690333005: [WPT Export] Fix remaining Git working directory bugs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_finder.py

Issue 2690333005: [WPT Export] Fix remaining Git working directory bugs (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from webkitpy.common.memoized import memoized

	6 from webkitpy.common.webkit_finder import WebKitFinder

	7

	8

	9 @memoized

	10 def absolute_chromium_wpt_dir(host):

	11 finder = WebKitFinder(host.filesystem)

	12 return finder.path_from_webkit_base('LayoutTests', 'external', 'wpt')

	13

	14

	15 @memoized

	16 def absolute_chromium_dir(host):

	17 finder = WebKitFinder(host.filesystem)

	18 return finder.chromium_base()
	jeffcarp 2017/02/14 21:07:26 I needed to create this file to avoid a cyclical d I needed to create this file to avoid a cyclical dependency between ChromiumCommit and Common, but lmk if there's a better way. I also considered just inlining the ChromiumCommit class into the common file.
OLD	NEW