Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py

Issue 2690333005: [WPT Export] Fix remaining Git working directory bugs (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
index 7dac6d5ce97ff0a1a071628ae347ca9bdc978310..17b8b893a7296bc920fb464b0633cb5d1dbf3238 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py
@@ -7,6 +7,7 @@
import logging
from webkitpy.w3c.chromium_commit import ChromiumCommit
+from webkitpy.w3c.chromium_finder import absolute_chromium_dir
WPT_DEST_NAME = 'wpt'
@@ -37,11 +38,15 @@ def exportable_commits_since(chromium_commit_hash, host, local_wpt):
A list of ChromiumCommit objects for commits that are exportable after
the given commit, in chronological order.
"""
- chromium_repo_root = host.executive.run_command(['git', 'rev-parse', '--show-toplevel']).strip()
+ chromium_repo_root = host.executive.run_command([
+ 'git', 'rev-parse', '--show-toplevel'
+ ], cwd=absolute_chromium_dir(host)).strip()
wpt_path = chromium_repo_root + '/' + CHROMIUM_WPT_DIR
commit_range = '{}..HEAD'.format(chromium_commit_hash)
- commit_hashes = host.executive.run_command(['git', 'rev-list', commit_range, '--reverse', '--', wpt_path]).splitlines()
+ commit_hashes = host.executive.run_command([
+ 'git', 'rev-list', commit_range, '--reverse', '--', wpt_path
+ ], cwd=absolute_chromium_dir(host)).splitlines()
chromium_commits = [ChromiumCommit(host, sha=sha) for sha in commit_hashes]
return [commit for commit in chromium_commits if is_exportable(commit, local_wpt)]

Powered by Google App Engine
This is Rietveld 408576698