Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2690183007: Calling container() on floats should only skip LayoutInline ancestors. (Closed)

Created:
3 years, 10 months ago by mstensho (USE GERRIT)
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, posciak+watch_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Calling container() on floats should only skip LayoutInline ancestors. We cannot use containingBlock() here, since container() needs to return non-LayoutBlock objects, such as LayoutVideo, because they serve as containing blocks for children inside them. BUG=688774

Patch Set 1 #

Patch Set 2 : Not so unreachable after all. container() is sometimes called on an unrooted tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/abspos-video-with-floated-control-crash.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/dynamic/abspos-video-with-floated-control-crash.html View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (8 generated)
mstensho (USE GERRIT)
3 years, 10 months ago (2017-02-16 10:58:29 UTC) #9 
This got fixed by https://codereview.chromium.org/2702473002/ - closing

Powered by Google App Engine
This is Rietveld 408576698