Don't allow out-of-flow positioned and floating children under LayoutMedia

Don't allow out-of-flow positioned and floating children under LayoutMedia

BUG=688774
R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2702473002 .
Cr-Commit-Position: refs/heads/master@{#450885}
Committed: https://chromium.googlesource.com/chromium/src/+/d8442090e4581bca53869f94c34a82e906a92910

[Xianzhu, 2017-02-15 23:04:58]

wangxianzhu@chromium.org changed reviewers:
+ eae@chromium.org, mstensho@opera.com

[eae, 2017-02-15 23:06:08]

OK

LGTM

[Xianzhu, 2017-02-15 23:08:57]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-02-15 23:08:57]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2702473002/#ps20001
(title: "Fix a typo")

[commit-bot: I haz the power, 2017-02-15 23:09:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 01:12:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:12:35]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Xianzhu, 2017-02-16 01:13:00]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-16 01:14:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 03:17:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:17:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Xianzhu, 2017-02-16 04:08:41]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-16 04:09:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-02-16 05:21:56]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2017-02-16 05:22:01]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:22:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 06:11:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:11:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Xianzhu, 2017-02-16 06:21:56]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:23:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-02-16 07:11:55]

Description was changed from

==========
Don't allow out-of-flow positioned and floating children under LayoutMedia

BUG=688774
==========

to

==========
Don't allow out-of-flow positioned and floating children under LayoutMedia

BUG=688774
R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2702473002 .
Cr-Commit-Position: refs/heads/master@{#450885}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8442090e4581bca53869f94c34a...
==========

[Xianzhu, 2017-02-16 07:11:56]

Committed patchset #2 (id:20001) manually as
d8442090e4581bca53869f94c34a82e906a92910 (presubmit successful).

[mstensho (USE GERRIT), 2017-02-16 10:56:43]

lgtm - I was working on https://codereview.chromium.org/2690183007/ to solve
this, which is about reverting the parts of
https://codereview.chromium.org/2575423003 that caused the problem. But I like
your fix better. :)

Hopefully there can no longer be a non-LayoutBlock between a float and the
nearest ancestor LayoutBlock that acts like a containing block. :-S