third_party/WebKit/LayoutTests/fast/multicol/dynamic/abspos-video-with-floated-control-crash.html - Issue 2690183007: Calling container() on floats should only skip LayoutInline ancestors.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/dynamic/abspos-video-with-floated-control-crash.html

Issue 2690183007: Calling container() on floats should only skip LayoutInline ancestors. (Closed)

Patch Set: Not so unreachable after all. container() is sometimes called on an unrooted tree. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #video::-webkit-media-controls { float:left; }

	4 </style>

	5 <div style="columns:3;">

	6 <span id="sibling"></span>

	7 <video id="video" style="position:absolute;"></video>

	8 </div>

	9 <script src="../../../resources/testharness.js"></script>

	10 <script src="../../../resources/testharnessreport.js"></script>

	11 <script>

	12 test(() => {

	13 document.body.offsetTop;

	14 document.getElementById("sibling").style.display = "none";

	15 document.body.offsetTop;

	16 document.getElementById("video").style.display = "none";

	17 }, "No crash or assertion failure.");

	18 </script>

OLD	NEW