Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2790473006: Replace IOAllowed with WaitAllowed in PlatformThread::Join()

Created:
3 years, 8 months ago by gab
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace IOAllowed with WaitAllowed in PlatformThread::Join() ... and enable the check on Windows as well. This was an IOAllowed check for legacy reasons (WaitAllowed was introduced later in the codebase) but Join() is much more of a wait operation (as highlighted in https://codereview.chromium.org/2690183002/). BUG=707362

Patch Set 1 #

Patch Set 2 : allow wait for ImageTransportFactory::Terminate() doing SingleThreadTaskGraphRunner::Shutdown #

Patch Set 3 : SetWaitAllowed(true) from ShutdownThreadsAndCleanUp() onward, just like SetIOAllowed() is set. #

Patch Set 4 : allow in IOThreadPreCleanup() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -94 lines) Patch
M base/threading/platform_thread_posix.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M base/threading/platform_thread_win.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M base/threading/thread_restrictions.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 2 chunks +78 lines, -81 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (17 generated)
gab
The CQ bit was checked by gab@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-31 19:58:42 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790473006/1
3 years, 8 months ago (2017-03-31 19:59:17 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-31 20:40:20 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/44091)
3 years, 8 months ago (2017-03-31 20:40:21 UTC) #4
gab
The CQ bit was checked by gab@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-31 20:52:43 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790473006/20001
3 years, 8 months ago (2017-03-31 20:53:31 UTC) #6
gab
Description was changed from ========== Replace IOAllowed with WaitAllowed in PlatformThread::Join() ... and enable the ...
3 years, 8 months ago (2017-03-31 20:54:13 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-31 21:44:31 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/338519)
3 years, 8 months ago (2017-03-31 21:44:31 UTC) #9
gab
The CQ bit was checked by gab@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-06 17:14:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790473006/40001
3 years, 8 months ago (2017-04-06 17:15:05 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-06 18:08:36 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/341997)
3 years, 8 months ago (2017-04-06 18:08:36 UTC) #13
gab
The CQ bit was checked by gab@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-06 19:43:58 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2790473006/60001
3 years, 8 months ago (2017-04-06 19:45:11 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-06 20:49:12 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 20:49:13 UTC) #17 
Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Powered by Google App Engine
This is Rietveld 408576698