Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2789923002: Fix destruction order of FileSystemContext in MediaFileValidatorTest. (Closed)

Created:
3 years, 8 months ago by gab
Modified:
3 years, 8 months ago
Reviewers:
tzik
CC:
chromium-reviews, Lei Zhang, tommycli, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix destruction order of FileSystemContext in MediaFileValidatorTest. Pre-requisite for https://codereview.chromium.org/2690183002/ Otherwise it causes: [7962:7962:0330/140009.008419:FATAL:task_tracker.cc(394)] Check failed: !shutdown_event_->IsSignaled(). #0 0x000002edc667 base::debug::StackTrace::StackTrace() #1 0x000002ef500b logging::LogMessage::~LogMessage() #2 0x000002f3f8b1 base::internal::TaskTracker::BeforePostTask() #3 0x000002f3f75f base::internal::TaskTracker::WillPostTask() #4 0x000002f93628 base::internal::SchedulerSingleThreadTaskRunnerManager::SchedulerSingleThreadTaskRunner::PostDelayedTask() #5 0x000002f4982b base::SequencedWorkerPool::PoolSequencedTaskRunner::PostNonNestableDelayedTask() #6 0x000002f24e4b base::SequencedTaskRunner::DeleteOrReleaseSoonInternal() #7 0x000004c6dce5 storage::FileSystemContext::DeleteOnCorrectThread() #8 0x000000c7232e MediaFileValidatorTest::~MediaFileValidatorTest() #9 0x000000c722a9 MediaFileValidatorTest_ValidAudio_Test::~MediaFileValidatorTest_ValidAudio_Test() #10 0x000003d7c391 testing::TestInfo::Run() #11 0x000003d7c867 testing::TestCase::Run() #12 0x000003d838a7 testing::internal::UnitTestImpl::RunAllTests() #13 0x000003d83527 testing::UnitTest::Run() #14 0x000002fcbc71 base::TestSuite::Run() #15 0x000002ecef48 ChromeTestSuiteRunner::RunTestSuite() #16 0x0000035e80ec content::LaunchTests() BUG=653916 Review-Url: https://codereview.chromium.org/2789923002 Cr-Commit-Position: refs/heads/master@{#461227} Committed: https://chromium.googlesource.com/chromium/src/+/c6f277128dfba1874ebd3e698ad01254faf9ff9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
gab
Taiju PTaL, thanks!
3 years, 8 months ago (2017-03-31 19:37:28 UTC) #4
tzik
lgtm
3 years, 8 months ago (2017-03-31 20:27:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789923002/1
3 years, 8 months ago (2017-03-31 20:39:44 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 21:07:10 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6f277128dfba1874ebd3e698ad0...

Powered by Google App Engine
This is Rietveld 408576698