Chromium Code Reviews
DescriptionRevert of Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2675383002/ )
Reason for revert:
Speculative revert. May be causing many test failures on the CrOS bot:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29
Original issue's description:
> Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.
>
> The following traits are used:
>
> Priority: Inherited (default)
> The priority is inherited from the calling context (i.e. TaskTraits
> are initialized with the priority of the current task).
>
> Shutdown behavior: CONTINUE_ON_SHUTDOWN
> Tasks posted with this mode which have not started executing before
> shutdown is initiated will never run. Tasks with this mode running at
> shutdown will be ignored (the worker will not be joined).
>
> Note: Tasks that were previously posted to base::WorkerPool should
> use this shutdown behavior because this is how base::WorkerPool
> handles all its tasks.
>
> May Block:
> Tasks posted with MayBlock() may block. This includes but is not
> limited to tasks that wait on synchronous file I/O operations:
> read or write a file from disk, interact with a pipe or a socket,
> rename or delete a file, enumerate files in a directory, etc. This
> trait isn't required for the mere use of locks.
>
> BUG=659191
>
> Review-Url: https://codereview.chromium.org/2675383002
> Cr-Commit-Position: refs/heads/master@{#449607}
> Committed: https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b29749656fec8
TBR=jochen@chromium.org,juliatuttle@chromium.org,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659191
Review-Url: https://codereview.chromium.org/2689813002
Cr-Commit-Position: refs/heads/master@{#449739}
Committed: https://chromium.googlesource.com/chromium/src/+/8d6746ffb3d857e3a493ab011f5d7c898a928576
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
||||||||||||||||||||||||||||