Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
Review-Url: https://codereview.chromium.org/2675383002
Cr-Original-Commit-Position: refs/heads/master@{#449607}
Committed: https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b29749656fec8
Review-Url: https://codereview.chromium.org/2675383002
Cr-Commit-Position: refs/heads/master@{#449801}
Committed: https://chromium.googlesource.com/chromium/src/+/bdbbd9b6c286d385f03b0286e2273e188c69e4b8

[fdoray, 2017-02-06 21:32:56]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:33:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 23:20:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 23:20:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2017-02-07 13:40:44]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 13:41:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 14:35:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 14:35:42]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-02-07 15:31:38]

fdoray@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[fdoray, 2017-02-07 15:31:39]

PTAL

[Julia Tuttle, 2017-02-09 16:01:13]

On 2017/02/07 15:31:39, fdoray wrote:
> PTAL

lgtm

[fdoray, 2017-02-09 16:05:06]

fdoray@chromium.org changed reviewers:
+ jochen@chromium.org

[fdoray, 2017-02-09 16:05:06]

jochen@: Please review changes in chrome/

[jochen (gone - plz use gerrit), 2017-02-10 09:04:47]

lgtm

[fdoray, 2017-02-10 12:29:20]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-02-10 12:29:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 13:58:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486729760302770,
"parent_rev": "1c496374204313ae4233bc19c6495c8c2b0ee660", "commit_rev":
"937fd873bf0791a2b402a7c32a7b29749656fec8"}

[commit-bot: I haz the power, 2017-02-10 13:59:18]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2675383002
Cr-Commit-Position: refs/heads/master@{#449607}
Committed:
https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b...
==========

[commit-bot: I haz the power, 2017-02-10 13:59:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b...

[Bret, 2017-02-10 21:22:49]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2689813002/ by bsep@chromium.org.

The reason for reverting is: Speculative revert. May be causing many test
failures on the CrOS bot:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C....

[Bret, 2017-02-11 00:07:37]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2675383002
Cr-Commit-Position: refs/heads/master@{#449607}
Committed:
https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b...
==========

to

==========
Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2675383002
Cr-Commit-Position: refs/heads/master@{#449607}
Committed:
https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b...
==========

[Bret, 2017-02-11 00:07:57]

On 2017/02/10 21:22:49, Bret Sepulveda wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2689813002/ by mailto:bsep@chromium.org.
> 
> The reason for reverting is: Speculative revert. May be causing many test
> failures on the CrOS bot:
>
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C....

Was not the culprit, relanding. Sorry!

[Bret, 2017-02-11 00:08:02]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-02-11 00:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 00:12:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486771682290840,
"parent_rev": "7b43c6890d5ba766cd9916fe7124af45bdd42f6a", "commit_rev":
"bdbbd9b6c286d385f03b0286e2273e188c69e4b8"}

[commit-bot: I haz the power, 2017-02-11 00:13:40]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2675383002
Cr-Commit-Position: refs/heads/master@{#449607}
Committed:
https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b...
==========

to

==========
Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc.

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2675383002
Cr-Original-Commit-Position: refs/heads/master@{#449607}
Committed:
https://chromium.googlesource.com/chromium/src/+/937fd873bf0791a2b402a7c32a7b...
Review-Url: https://codereview.chromium.org/2675383002
Cr-Commit-Position: refs/heads/master@{#449801}
Committed:
https://chromium.googlesource.com/chromium/src/+/bdbbd9b6c286d385f03b0286e227...
==========

[commit-bot: I haz the power, 2017-02-11 00:13:41]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bdbbd9b6c286d385f03b0286e227...