Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: chrome/browser/browser_process_impl_unittest.cc

Issue 2689813002: Revert of Use TaskScheduler instead of WorkerPool in tcp_socket_posix.cc. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/tcp_socket_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl_unittest.cc
diff --git a/chrome/browser/browser_process_impl_unittest.cc b/chrome/browser/browser_process_impl_unittest.cc
index c7d841439e9b6234ec67f5332f00acc363ff9192..fb32806e2719e90be96579cc9804dc28f76001c6 100644
--- a/chrome/browser/browser_process_impl_unittest.cc
+++ b/chrome/browser/browser_process_impl_unittest.cc
@@ -7,11 +7,9 @@
#include <memory>
#include "base/command_line.h"
-#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/user_metrics.h"
#include "base/run_loop.h"
-#include "base/test/scoped_task_scheduler.h"
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile_manager.h"
@@ -48,8 +46,6 @@
// The UI thread needs to be alive while BrowserProcessImpl is alive, and is
// managed separately.
void StartSecondaryThreads() {
- scoped_task_scheduler_ = base::MakeUnique<base::test::ScopedTaskScheduler>(
- base::MessageLoop::current());
file_thread_->StartIOThread();
io_thread_->StartIOThread();
}
@@ -64,7 +60,6 @@
base::RunLoop().RunUntilIdle();
file_thread_.reset();
base::RunLoop().RunUntilIdle();
- scoped_task_scheduler_.reset();
}
BrowserProcessImpl* browser_process_impl() {
@@ -75,7 +70,6 @@
BrowserProcess* stashed_browser_process_;
base::MessageLoop loop_;
content::TestBrowserThread ui_thread_;
- std::unique_ptr<base::test::ScopedTaskScheduler> scoped_task_scheduler_;
std::unique_ptr<content::TestBrowserThread> file_thread_;
std::unique_ptr<content::TestBrowserThread> io_thread_;
base::CommandLine command_line_;
« no previous file with comments | « no previous file | net/socket/tcp_socket_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698