Add a helper method to create SW SimpleEventCallbacks.

Add a helper method to create SW SimpleEventCallbacks.

It's safe to use base::Unretained() for callee ownership in these
callbacks, but in order to avoid repeated documentation of the same
thing (or undocumented usage of base::Unretained()) we should unify it.

BUG=

Review-Url: https://codereview.chromium.org/2689693003
Cr-Commit-Position: refs/heads/master@{#449964}
Committed: https://chromium.googlesource.com/chromium/src/+/60a80920d08803efce7fadbe9f60c6eb4b90da4a

[Peter Beverloo, 2017-02-10 17:41:02]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[Peter Beverloo, 2017-02-10 17:41:12]

peter@chromium.org changed reviewers:
+ shimazu@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 19:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 19:34:09]

Dry run: This issue passed the CQ dry run.

[shimazu, 2017-02-13 00:28:52]

Thanks for working on this!
Added a comment.

https://codereview.chromium.org/2689693003/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/2689693003/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version.h:438: base::Time
dispatch_event_time);
Could you use CreateSimpleEventCallback at service_worker_version_unittest.cc
l.917
(https://cs.chromium.org/chromium/src/content/browser/service_worker/service_w...)
and move OnSimpleEventFinished to private?

[Peter Beverloo, 2017-02-13 14:08:40]

https://codereview.chromium.org/2689693003/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version.h (right):

https://codereview.chromium.org/2689693003/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version.h:438: base::Time
dispatch_event_time);
On 2017/02/13 00:28:52, shimazu wrote:
> Could you use CreateSimpleEventCallback at service_worker_version_unittest.cc
> l.917
>
(https://cs.chromium.org/chromium/src/content/browser/service_worker/service_w...)
> and move OnSimpleEventFinished to private?

Done.

[Peter Beverloo, 2017-02-13 14:08:47]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 14:08:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shimazu, 2017-02-13 14:21:23]

LGTM, thanks:)

[commit-bot: I haz the power, 2017-02-13 15:32:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 15:32:43]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-02-13 15:35:56]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-02-13 15:36:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 15:40:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487000156678860,
"parent_rev": "d402a56f17a6d790d92607c66580720e2cdf94ba", "commit_rev":
"60a80920d08803efce7fadbe9f60c6eb4b90da4a"}

[commit-bot: I haz the power, 2017-02-13 15:41:15]

Description was changed from

==========
Add a helper method to create SW SimpleEventCallbacks.

It's safe to use base::Unretained() for callee ownership in these
callbacks, but in order to avoid repeated documentation of the same
thing (or undocumented usage of base::Unretained()) we should unify it.

BUG=
==========

to

==========
Add a helper method to create SW SimpleEventCallbacks.

It's safe to use base::Unretained() for callee ownership in these
callbacks, but in order to avoid repeated documentation of the same
thing (or undocumented usage of base::Unretained()) we should unify it.

BUG=

Review-Url: https://codereview.chromium.org/2689693003
Cr-Commit-Position: refs/heads/master@{#449964}
Committed:
https://chromium.googlesource.com/chromium/src/+/60a80920d08803efce7fadbe9f60...
==========

[commit-bot: I haz the power, 2017-02-13 15:41:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60a80920d08803efce7fadbe9f60...