Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2921)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 2689693003: Add a helper method to create SW SimpleEventCallbacks. (Closed)
Patch Set: Add a helper method to create SW SimpleEventCallbacks. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index 5639e4da0110dc9b78cf696bed17a09a02fc5222..7558a4c5aae1a5801885636d695407436719bcea 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -914,8 +914,8 @@ TEST_F(ServiceWorkerRequestTimeoutTest, RequestTimeout) {
EXPECT_FALSE(extendable_message_event_callback());
version_->event_dispatcher()->DispatchExtendableMessageEvent(
mojom::ExtendableMessageEvent::New(),
- base::Bind(&ServiceWorkerVersion::OnSimpleEventFinished, version_,
- request_id));
+ version_->CreateSimpleEventCallback(request_id));
+
base::RunLoop().RunUntilIdle();
// The renderer should have received an ExtendableMessageEvent request.
EXPECT_TRUE(extendable_message_event_callback());
« no previous file with comments | « content/browser/service_worker/service_worker_version.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698