Add a helper method to create SW SimpleEventCallbacks.

content/browser/service_worker/service_worker_version.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_
 
 #include <stdint.h>
 
 #include <functional>
@@ skipping 55 matching lines @@
 // This class corresponds to a specific version of a ServiceWorker
 // script for a given pattern. When a script is upgraded, there may be
 // more than one ServiceWorkerVersion "running" at a time, but only
 // one of them is activated. This class connects the actual script with a
 // running worker.
 class CONTENT_EXPORT ServiceWorkerVersion
     : NON_EXPORTED_BASE(public base::RefCounted<ServiceWorkerVersion>),
       public EmbeddedWorkerInstance::Listener {
  public:
   using StatusCallback = base::Callback<void(ServiceWorkerStatusCode)>;
+  using SimpleEventCallback =
+      base::Callback<void(ServiceWorkerStatusCode, base::Time)>;
 
   // Current version status; some of the status (e.g. INSTALLED and ACTIVATED)
   // should be persisted unlike running status.
   enum Status {
     NEW,         // The version is just created.
     INSTALLING,  // Install event is dispatched and being handled.
     INSTALLED,   // Install event is finished and is ready to be activated.
     ACTIVATING,  // Activate event is dispatched and being handled.
     ACTIVATED,   // Activation is finished and can run as activated.
     REDUNDANT,   // The version is no longer running as activated, due to
@@ skipping 182 matching lines @@
   // TODO(mek): Use something other than a bool for event status.
   bool FinishRequest(int request_id,
                      bool was_handled,
                      base::Time dispatch_event_time);
 
   // Finishes an external request that was started by StartExternalRequest().
   // Returns false if there was an error finishing the request: e.g. the request
   // was not found or the worker already terminated.
   bool FinishExternalRequest(const std::string& request_uuid);
 
+  // Creates a callback that is to be used for marking simple events dispatched
+  // through the ServiceWorkerEventDispatcher as finished for the |request_id|.
+  SimpleEventCallback CreateSimpleEventCallback(int request_id);
+
   // This must be called when the worker is running.
   mojom::ServiceWorkerEventDispatcher* event_dispatcher() {
     DCHECK(event_dispatcher_.is_bound());
     return event_dispatcher_.get();
   }
 
   // Dispatches an event. If dispatching the event fails, all of the error
   // callbacks that were associated with |request_ids| via StartRequest are
   // called.
   // Use RegisterRequestCallback or RegisterSimpleRequest to register a callback
@@ skipping 134 matching lines @@
   // expiration time expires.
   base::TimeDelta remaining_timeout() const {
     return max_request_expiration_time_ - tick_clock_->NowTicks();
   }
 
   // Callback function for simple events dispatched through mojo interface
   // mojom::ServiceWorkerEventDispatcher, once all simple events got dispatched
   // through mojo, OnSimpleEventResponse function could be removed.
   void OnSimpleEventFinished(int request_id,
                              ServiceWorkerStatusCode status,
                              base::Time dispatch_event_time);

[shimazu, 2017/02/13 00:28:52]

Could you use CreateSimpleEventCallback at service_worker_version_unittest.cc
l.917
(https://cs.chromium.org/chromium/src/content/browser/service_worker/service_w...)
and move OnSimpleEventFinished to private?

[Peter Beverloo, 2017/02/13 14:08:40]

Done.

 
   // Returns the Navigation Preload support status of the service worker.
   //  - Origin Trial: Have an effective token.
   //                                 Command line
   //                             Default  Enable  Disabled
   //                   Default      A       A        B2
   //      Field trial  Enabled      A       A        B2
   //                   Disabled     B1      A        B2
   //
   //  - Origin Trial: No token.
@@ skipping 452 matching lines @@
 
   // At this point |this| can have been deleted, so don't do anything other
   // than returning.
 
   return true;
 }
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_