Inline base::BinaryValue into base::Value

Inline base::BinaryValue into base::Value

Similarly as done with base::FundamentalValue and base::StringValue we inline
base::BinaryValue into base::Value. There will be a follow up CL updating all
call sites to use base::Value instead of base::BinaryValue, again similarly to
how the removal of base::FundamentalValue and base::StringValue was done.

BUG=646113
R=brettw@chromium.org
CC=vabr@chromium.org

Review-Url: https://codereview.chromium.org/2689673002
Cr-Commit-Position: refs/heads/master@{#450640}
Committed: https://chromium.googlesource.com/chromium/src/+/e03e80f36e9c4830acd4138211bfe1e600db987b

[jdoerrie, 2017-02-10 10:42:33]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 10:42:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-02-10 11:00:35]

Hi brettw@, please take a look.

https://codereview.chromium.org/2689673002/diff/1/base/values.h
File base/values.h (left):

https://codereview.chromium.org/2689673002/diff/1/base/values.h#oldcode176
base/values.h:176: BinaryValue();
Having the empty constructor create BinaryValues is impossible now. You need to
call Value(Value::Type::BINARY) to get a BinaryValue with an empty buffer. In
addition, buffer should never be null anymore.

https://codereview.chromium.org/2689673002/diff/1/base/values.h#oldcode180
base/values.h:180: BinaryValue(std::unique_ptr<char[]> buffer, size_t size);
This constructor was rarely used, and is completely dropped in favor of
Value(std::vector<char>&&).

https://codereview.chromium.org/2689673002/diff/1/base/values.h#oldcode194
base/values.h:194: const char* GetBuffer() const { return buffer_.get(); }
Every call site of |GetBuffer| can make use of the const version, so I decided
to simply drop the non const version. This is similar to how we decided to drop
the non-const GetString&.

https://codereview.chromium.org/2689673002/diff/1/content/child/v8_value_conv...
File content/child/v8_value_converter_impl.cc (right):

https://codereview.chromium.org/2689673002/diff/1/content/child/v8_value_conv...
content/child/v8_value_converter_impl.cc:504: view->CopyContents(buffer.data(),
buffer.size());
Unfortunately, this will always zero initialize |buffer| now, which is unneeded
here. I considered using |buffer.reserve(byte_length)| instead, but this SO
answer claims this wouldn't be safe: http://stackoverflow.com/a/8228861

[commit-bot: I haz the power, 2017-02-10 12:21:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 12:21:24]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jdoerrie, 2017-02-10 15:01:48]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 15:02:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 16:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:23:32]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[jdoerrie, 2017-02-14 12:41:46]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 12:42:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 15:23:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 15:23:48]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-02-14 22:59:39]

lgtm

[jdoerrie, 2017-02-15 08:35:23]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-02-15 08:35:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 08:42:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487147723092700,
"parent_rev": "4eb44ba97feef5014b971f26994b2c0db5370c6d", "commit_rev":
"e03e80f36e9c4830acd4138211bfe1e600db987b"}

[commit-bot: I haz the power, 2017-02-15 08:42:55]

Description was changed from

==========
Inline base::BinaryValue into base::Value

Similarly as done with base::FundamentalValue and base::StringValue we inline
base::BinaryValue into base::Value. There will be a follow up CL updating all
call sites to use base::Value instead of base::BinaryValue, again similarly to
how the removal of base::FundamentalValue and base::StringValue was done.

BUG=646113
R=brettw@chromium.org
CC=vabr@chromium.org
==========

to

==========
Inline base::BinaryValue into base::Value

Similarly as done with base::FundamentalValue and base::StringValue we inline
base::BinaryValue into base::Value. There will be a follow up CL updating all
call sites to use base::Value instead of base::BinaryValue, again similarly to
how the removal of base::FundamentalValue and base::StringValue was done.

BUG=646113
R=brettw@chromium.org
CC=vabr@chromium.org

Review-Url: https://codereview.chromium.org/2689673002
Cr-Commit-Position: refs/heads/master@{#450640}
Committed:
https://chromium.googlesource.com/chromium/src/+/e03e80f36e9c4830acd4138211bf...
==========

[commit-bot: I haz the power, 2017-02-15 08:42:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e03e80f36e9c4830acd4138211bf...