Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chromecast/base/serializers_unittest.cc

Issue 2689673002: Inline base::BinaryValue into base::Value (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/base/serializers_unittest.cc
diff --git a/chromecast/base/serializers_unittest.cc b/chromecast/base/serializers_unittest.cc
index d5c4189a7b71b4bd07c54af81758fe7e8186cc34..8dc9b071025b400d87b62e321348f2c2f4609754 100644
--- a/chromecast/base/serializers_unittest.cc
+++ b/chromecast/base/serializers_unittest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <vector>
+
#include "base/files/file_util.h"
#include "base/values.h"
#include "chromecast/base/scoped_temp_file.h"
@@ -53,7 +55,7 @@ TEST(DeserializeFromJson, PoorlyFormedJsonObject) {
}
TEST(SerializeToJson, BadValue) {
- base::BinaryValue value(std::unique_ptr<char[]>(new char[12]), 12);
+ base::BinaryValue value(std::vector<char>(12));
std::unique_ptr<std::string> str = SerializeToJson(value);
EXPECT_EQ(nullptr, str.get());
}
@@ -116,7 +118,7 @@ TEST(DeserializeJsonFromFile, PoorlyFormedJsonObject) {
TEST(SerializeJsonToFile, BadValue) {
ScopedTempFile temp;
- base::BinaryValue value(std::unique_ptr<char[]>(new char[12]), 12);
+ base::BinaryValue value(std::vector<char>(12));
ASSERT_FALSE(SerializeJsonToFile(temp.path(), value));
std::string str(temp.Read());
EXPECT_TRUE(str.empty());
« no previous file with comments | « chrome/renderer/media/cast_session_delegate.cc ('k') | components/search_engines/default_search_policy_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698