Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3084)

Unified Diff: extensions/browser/api/cast_channel/cast_message_util.cc

Issue 2689673002: Inline base::BinaryValue into base::Value (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_message_util.cc
diff --git a/extensions/browser/api/cast_channel/cast_message_util.cc b/extensions/browser/api/cast_channel/cast_message_util.cc
index 3726efdacbc819bca9c414530e97e94b72239875..7cdf1c5aca13ddcc73e2dcaef362c68c82827eb2 100644
--- a/extensions/browser/api/cast_channel/cast_message_util.cc
+++ b/extensions/browser/api/cast_channel/cast_message_util.cc
@@ -37,7 +37,6 @@ bool MessageInfoToCastMessage(const MessageInfo& message,
// Determine the type of the base::Value and set the message payload
// appropriately.
std::string data;
- base::BinaryValue* real_value;
switch (message.data->GetType()) {
// JS string
case base::Value::Type::STRING:
@@ -48,12 +47,9 @@ bool MessageInfoToCastMessage(const MessageInfo& message,
break;
// JS ArrayBuffer
case base::Value::Type::BINARY:
- real_value = static_cast<base::BinaryValue*>(message.data.get());
- if (real_value->GetBuffer()) {
- message_proto->set_payload_type(CastMessage_PayloadType_BINARY);
- message_proto->set_payload_binary(real_value->GetBuffer(),
- real_value->GetSize());
- }
+ message_proto->set_payload_type(CastMessage_PayloadType_BINARY);
+ message_proto->set_payload_binary(message.data->GetBuffer(),
+ message.data->GetSize());
break;
default:
// Unknown value type. message_proto will remain uninitialized because
« no previous file with comments | « extensions/browser/api/cast_channel/cast_channel_api.cc ('k') | extensions/browser/api/socket/socket_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698