Migrate WTF::HashSet::add() to ::insert() [continued]

Migrate WTF::HashSet::add() to ::insert() [continued]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL continues the migration process from add() to insert() and
removes one of the add() methods from HashSet.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
Review-Url: https://codereview.chromium.org/2688893002
Cr-Commit-Position: refs/heads/master@{#449981}
Committed: https://chromium.googlesource.com/chromium/src/+/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9

[pilgrim_google, 2017-02-10 17:10:01]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 17:10:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:55:34]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[pilgrim_google, 2017-02-11 02:10:02]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2017-02-11 02:10:19]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2017-02-11 02:10:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 04:12:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-11 04:12:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[haraken, 2017-02-11 09:33:43]

LGTM

https://codereview.chromium.org/2688893002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/HashSet.h (right):

https://codereview.chromium.org/2688893002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/HashSet.h:270: //}

Can we remove this?

[pilgrim_google, 2017-02-13 15:28:43]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-02-13 15:28:43]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2688893002/#ps60001
(title: "rebase, fix one platform-specific reference")

[pilgrim_google, 2017-02-13 15:28:57]

On 2017/02/11 at 09:33:43, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/2688893002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/wtf/HashSet.h (right):
> 
>
https://codereview.chromium.org/2688893002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/wtf/HashSet.h:270: //}
> 
> Can we remove this?

Fixed in patch 4.

[commit-bot: I haz the power, 2017-02-13 15:28:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 17:05:19]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486999723068070,
"parent_rev": "1c88bac5c868c7345259568ee80dd684ce8ffa25", "commit_rev":
"1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9"}

[commit-bot: I haz the power, 2017-02-13 17:05:52]

Description was changed from

==========
Migrate WTF::HashSet::add() to ::insert() [continued]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL continues the migration process from add() to insert() and
removes one of the add() methods from HashSet.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::HashSet::add() to ::insert() [continued]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL continues the migration process from add() to insert() and
removes one of the add() methods from HashSet.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Review-Url: https://codereview.chromium.org/2688893002
Cr-Commit-Position: refs/heads/master@{#449981}
Committed:
https://chromium.googlesource.com/chromium/src/+/1dc76b0c12e43cce0f8ca56e38c2...
==========

[commit-bot: I haz the power, 2017-02-13 17:05:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1dc76b0c12e43cce0f8ca56e38c2...