Migrate WTF::HashSet::add() to ::insert() [continued]

third_party/WebKit/Source/wtf/HashSet.h

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 90 matching lines @@
   //   static bool equal(const ValueType&, const T&);
   template <typename HashTranslator, typename T>
   iterator find(const T&) const;
   template <typename HashTranslator, typename T>
   bool contains(const T&) const;
 
   // The return value is a pair of an iterator to the new value's location,
   // and a bool that is true if an new entry was added.
   template <typename IncomingValueType>
   AddResult insert(IncomingValueType&&);
-  template <typename IncomingValueType>
-  AddResult add(IncomingValueType&&);
+  // TODO(pilgrim) remove this
+  // template <typename IncomingValueType>
+  // AddResult add(IncomingValueType&&);
 
   // An alternate version of add() that finds the object by hashing and
   // comparing with some other type, to avoid the cost of type conversion if
   // the object is already in the table. HashTranslator must have the
   // following function members:
   //   static unsigned hash(const T&);
   //   static bool equal(const ValueType&, const T&);
   //   static translate(ValueType&, T&&, unsigned hashCode);
   template <typename HashTranslator, typename T>
   AddResult addWithTranslator(T&&);
@@ skipping 131 matching lines @@
 
 template <typename T, typename U, typename V, typename W>
 template <typename IncomingValueType>
 inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::insert(
     IncomingValueType&& value) {
   return m_impl.add(std::forward<IncomingValueType>(value));
 }
 
 // TODO(pilgrim) remove this method once all references and subclasses
 // have been migrated to insert() method
-template <typename T, typename U, typename V, typename W>
-template <typename IncomingValueType>
-inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::add(
-    IncomingValueType&& value) {
-  return m_impl.add(std::forward<IncomingValueType>(value));
-}
+// template <typename T, typename U, typename V, typename W>
+// template <typename IncomingValueType>
+// inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::add(
+//    IncomingValueType&& value) {
+//  return m_impl.add(std::forward<IncomingValueType>(value));
+//}

[haraken, 2017/02/11 09:33:43]

Can we remove this?

 
 template <typename Value,
           typename HashFunctions,
           typename Traits,
           typename Allocator>
 template <typename HashTranslator, typename T>
 inline typename HashSet<Value, HashFunctions, Traits, Allocator>::AddResult
 HashSet<Value, HashFunctions, Traits, Allocator>::addWithTranslator(T&& value) {
   // Forward only the first argument, because the second argument isn't actually
   // used in HashSetTranslatorAdapter.
@@ skipping 52 matching lines @@
   iterator end = collection.end();
   for (unsigned i = 0; it != end; ++it, ++i)
     vector[i] = *it;
 }
 
 }  // namespace WTF
 
 using WTF::HashSet;
 
 #endif  // WTF_HashSet_h