Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: third_party/WebKit/Source/wtf/HashSet.h

Issue 2688893002: Migrate WTF::HashSet::add() to ::insert() [continued] (Closed)
Patch Set: rebase, fix one platform-specific reference Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/HashSet.h
diff --git a/third_party/WebKit/Source/wtf/HashSet.h b/third_party/WebKit/Source/wtf/HashSet.h
index e50fcb2b167d086727dc69d1f0f28ff438e6830e..f1af65b68c09b025e8dfff98b4973ce332cf6ea7 100644
--- a/third_party/WebKit/Source/wtf/HashSet.h
+++ b/third_party/WebKit/Source/wtf/HashSet.h
@@ -108,8 +108,9 @@ class HashSet {
// and a bool that is true if an new entry was added.
template <typename IncomingValueType>
AddResult insert(IncomingValueType&&);
- template <typename IncomingValueType>
- AddResult add(IncomingValueType&&);
+ // TODO(pilgrim) remove this
+ // template <typename IncomingValueType>
+ // AddResult add(IncomingValueType&&);
// An alternate version of add() that finds the object by hashing and
// comparing with some other type, to avoid the cost of type conversion if
@@ -259,15 +260,6 @@ inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::insert(
return m_impl.add(std::forward<IncomingValueType>(value));
}
-// TODO(pilgrim) remove this method once all references and subclasses
-// have been migrated to insert() method
-template <typename T, typename U, typename V, typename W>
-template <typename IncomingValueType>
-inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::add(
- IncomingValueType&& value) {
- return m_impl.add(std::forward<IncomingValueType>(value));
-}
-
template <typename Value,
typename HashFunctions,
typename Traits,
« no previous file with comments | « third_party/WebKit/Source/web/CompositorMutatorImpl.cpp ('k') | third_party/WebKit/Source/wtf/LinkedHashSet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698