Re-enable DCHECK for pointertypes of coalesced events

Re-enable DCHECK for pointertypes of coalesced events

The modified DCHECK was failing on MAC when mouse was
leaving window due to the missing pointer type from
the event Chrome was receiveing from the OS. So we
were setting the pointerType to Unknown.
After the following fix:
https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240cfeed865e520
we have a heuristic in place to set the type to either
pen or mouse. So this DCHECK can be enabled again.

BUG=684292
Review-Url: https://codereview.chromium.org/2688793003
Cr-Commit-Position: refs/heads/master@{#450075}
Committed: https://chromium.googlesource.com/chromium/src/+/6b4cb83ed1e58193e8f3935ff406ce0ddb6310c6

[Navid Zolghadr, 2017-02-10 19:35:41]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 19:36:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-02-10 19:36:35]

nzolghadr@chromium.org changed reviewers:
+ bokan@chromium.org, mustaq@chromium.org

[mustaq, 2017-02-10 19:44:43]

lgtm

[commit-bot: I haz the power, 2017-02-10 22:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:03:36]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2017-02-13 16:36:16]

nzolghadr@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2017-02-13 19:05:59]

LGTM

[Navid Zolghadr, 2017-02-13 19:07:33]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-02-13 19:07:48]

Description was changed from

==========
Re-enable DCHECK for pointertypes of coalesced events

The modified DHECK was failing on MAC when mouse was
leaving window due to the missing pointer type from
the event Chrome was receiveing from the OS. So we
were setting the pointerType to Unknown.
After the following fix:
https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240...
we have a heuristic in place to set the type to either
pen or mouse. So this DCHECK can be enabled again.

BUG=684292
==========

to

==========
Re-enable DCHECK for pointertypes of coalesced events

The modified DCHECK was failing on MAC when mouse was
leaving window due to the missing pointer type from
the event Chrome was receiveing from the OS. So we
were setting the pointerType to Unknown.
After the following fix:
https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240...
we have a heuristic in place to set the type to either
pen or mouse. So this DCHECK can be enabled again.

BUG=684292
==========

[commit-bot: I haz the power, 2017-02-13 19:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 20:49:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487012853139900, "parent_rev":
"853ae34d50f8322dbc272b7d92382a6a3ce3a0ab", "commit_rev":
"6b4cb83ed1e58193e8f3935ff406ce0ddb6310c6"}

[commit-bot: I haz the power, 2017-02-13 20:50:04]

Description was changed from

==========
Re-enable DCHECK for pointertypes of coalesced events

The modified DCHECK was failing on MAC when mouse was
leaving window due to the missing pointer type from
the event Chrome was receiveing from the OS. So we
were setting the pointerType to Unknown.
After the following fix:
https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240...
we have a heuristic in place to set the type to either
pen or mouse. So this DCHECK can be enabled again.

BUG=684292
==========

to

==========
Re-enable DCHECK for pointertypes of coalesced events

The modified DCHECK was failing on MAC when mouse was
leaving window due to the missing pointer type from
the event Chrome was receiveing from the OS. So we
were setting the pointerType to Unknown.
After the following fix:
https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240...
we have a heuristic in place to set the type to either
pen or mouse. So this DCHECK can be enabled again.

BUG=684292

Review-Url: https://codereview.chromium.org/2688793003
Cr-Commit-Position: refs/heads/master@{#450075}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b4cb83ed1e58193e8f3935ff406...
==========

[commit-bot: I haz the power, 2017-02-13 20:50:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b4cb83ed1e58193e8f3935ff406...

[alph, 2017-02-17 19:35:07]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2706513002/ by alph@chromium.org.

The reason for reverting is: Caused flakiness of
WebRtcFromWebAccessibleResourceTest.GetUserMediaInWebAccessibleResourceFail

https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9....

[alph, 2017-02-21 21:08:46]

Description was changed from

==========
Re-enable DCHECK for pointertypes of coalesced events

The modified DCHECK was failing on MAC when mouse was
leaving window due to the missing pointer type from
the event Chrome was receiveing from the OS. So we
were setting the pointerType to Unknown.
After the following fix:
https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240...
we have a heuristic in place to set the type to either
pen or mouse. So this DCHECK can be enabled again.

BUG=684292

Review-Url: https://codereview.chromium.org/2688793003
Cr-Commit-Position: refs/heads/master@{#450075}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b4cb83ed1e58193e8f3935ff406...
==========

to

==========
Re-enable DCHECK for pointertypes of coalesced events

The modified DCHECK was failing on MAC when mouse was
leaving window due to the missing pointer type from
the event Chrome was receiveing from the OS. So we
were setting the pointerType to Unknown.
After the following fix:
https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240...
we have a heuristic in place to set the type to either
pen or mouse. So this DCHECK can be enabled again.

BUG=684292

Review-Url: https://codereview.chromium.org/2688793003
Cr-Commit-Position: refs/heads/master@{#450075}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b4cb83ed1e58193e8f3935ff406...
==========

[alph, 2017-02-21 21:09:48]

On 2017/02/17 19:35:07, alph wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2706513002/ by mailto:alph@chromium.org.
> 
> The reason for reverting is: Caused flakiness of
> WebRtcFromWebAccessibleResourceTest.GetUserMediaInWebAccessibleResourceFail
> 
>
https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9....

Turned out that it was other DCHECK was failing, the one about matching ids.
So I'm relanding the patch.

[alph, 2017-02-21 21:09:54]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alph, 2017-02-21 21:22:06]

alph@chromium.org changed reviewers:
- alph@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:15:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:15:21]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[alph, 2017-02-21 23:27:39]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:35:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:35:42]

Exceeded global retry quota

[alph, 2017-02-22 01:39:56]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:41:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:43:27]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Navid Zolghadr, 2017-02-22 18:09:03]

On 2017/02/22 03:43:27, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build
> URL)

alph@ any update on relanding this patch?

[alph, 2017-02-22 21:32:21]

The CQ bit was checked by alph@chromium.org

[alph, 2017-02-22 21:32:44]

On 2017/02/22 18:09:03, Navid Zolghadr wrote:
> On 2017/02/22 03:43:27, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
> build
> > URL)
> 
> alph@ any update on relanding this patch?

I'm trying to. CQ is flaky.

[commit-bot: I haz the power, 2017-02-22 21:33:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 21:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 21:37:52]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)