Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2706513002: Revert of Re-enable DCHECK for pointertypes of coalesced events (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable DCHECK for pointertypes of coalesced events (patchset #1 id:1 of https://codereview.chromium.org/2688793003/ ) Reason for revert: Caused flakiness of WebRtcFromWebAccessibleResourceTest.GetUserMediaInWebAccessibleResourceFail https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVgsSBUZsYWtlIktXZWJSdGNGcm9tV2ViQWNjZXNzaWJsZVJlc291cmNlVGVzdC5HZXRVc2VyTWVkaWFJbldlYkFjY2Vzc2libGVSZXNvdXJjZUZhaWwM Original issue's description: > Re-enable DCHECK for pointertypes of coalesced events > > The modified DCHECK was failing on MAC when mouse was > leaving window due to the missing pointer type from > the event Chrome was receiveing from the OS. So we > were setting the pointerType to Unknown. > After the following fix: > https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240cfeed865e520 > we have a heuristic in place to set the type to either > pen or mouse. So this DCHECK can be enabled again. > > BUG=684292 > > Review-Url: https://codereview.chromium.org/2688793003 > Cr-Commit-Position: refs/heads/master@{#450075} > Committed: https://chromium.googlesource.com/chromium/src/+/6b4cb83ed1e58193e8f3935ff406ce0ddb6310c6 TBR=mustaq@chromium.org,bokan@chromium.org,rbyers@chromium.org,nzolghadr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=684292 Review-Url: https://codereview.chromium.org/2706513002 Cr-Commit-Position: refs/heads/master@{#451427} Committed: https://chromium.googlesource.com/chromium/src/+/47542d73322fa629f5d02975b7a2694089b28a58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/events/PointerEventFactory.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
alph
Created Revert of Re-enable DCHECK for pointertypes of coalesced events
3 years, 10 months ago (2017-02-17 19:35:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706513002/1
3 years, 10 months ago (2017-02-17 19:36:11 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/312192)
3 years, 10 months ago (2017-02-17 20:38:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706513002/1
3 years, 10 months ago (2017-02-17 21:45:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-17 23:47:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706513002/1
3 years, 10 months ago (2017-02-18 00:07:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 02:11:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706513002/1
3 years, 10 months ago (2017-02-18 05:43:28 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 06:26:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/47542d73322fa629f5d02975b7a2...

Powered by Google App Engine
This is Rietveld 408576698