DescriptionRevert of Re-enable DCHECK for pointertypes of coalesced events (patchset #1 id:1 of https://codereview.chromium.org/2688793003/ )
Reason for revert:
Caused flakiness of WebRtcFromWebAccessibleResourceTest.GetUserMediaInWebAccessibleResourceFail
https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVgsSBUZsYWtlIktXZWJSdGNGcm9tV2ViQWNjZXNzaWJsZVJlc291cmNlVGVzdC5HZXRVc2VyTWVkaWFJbldlYkFjY2Vzc2libGVSZXNvdXJjZUZhaWwM
Original issue's description:
> Re-enable DCHECK for pointertypes of coalesced events
>
> The modified DCHECK was failing on MAC when mouse was
> leaving window due to the missing pointer type from
> the event Chrome was receiveing from the OS. So we
> were setting the pointerType to Unknown.
> After the following fix:
> https://chromium.googlesource.com/chromium/src/+/e97eb52977dd7ed3936227f0d240cfeed865e520
> we have a heuristic in place to set the type to either
> pen or mouse. So this DCHECK can be enabled again.
>
> BUG=684292
>
> Review-Url: https://codereview.chromium.org/2688793003
> Cr-Commit-Position: refs/heads/master@{#450075}
> Committed: https://chromium.googlesource.com/chromium/src/+/6b4cb83ed1e58193e8f3935ff406ce0ddb6310c6
TBR=mustaq@chromium.org,bokan@chromium.org,rbyers@chromium.org,nzolghadr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=684292
Review-Url: https://codereview.chromium.org/2706513002
Cr-Commit-Position: refs/heads/master@{#451427}
Committed: https://chromium.googlesource.com/chromium/src/+/47542d73322fa629f5d02975b7a2694089b28a58
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
|