Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Issue 2688793003: Re-enable DCHECK for pointertypes of coalesced events (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/events/PointerEventFactory.cpp
diff --git a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
index f2840ccc5a70b95b13e2569525b794371f80082e..2e35440d5acc2d8a74f300ca1ca2320adbb687ea 100644
--- a/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
+++ b/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
@@ -265,9 +265,7 @@ PointerEvent* PointerEventFactory::create(
HeapVector<Member<PointerEvent>> coalescedPointerEvents;
for (const auto& coalescedMouseEvent : coalescedMouseEvents) {
DCHECK_EQ(mouseEvent.id, coalescedMouseEvent.id);
- // TODO(crbug.com/684292): We need further investigation of why the
- // following DCHECK fails.
- // DCHECK_EQ(mouseEvent.pointerType, coalescedMouseEvent.pointerType);
+ DCHECK_EQ(mouseEvent.pointerType, coalescedMouseEvent.pointerType);
PointerEventInit coalescedEventInit = pointerEventInit;
updateMousePointerEventInit(coalescedMouseEvent, view,
&coalescedEventInit);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698