Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issue 2688383003: Remove unnecessary SafePointScope (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, blink-reviews-api_chromium.org, blink-reviews-events_chromium.org, eae+blinkwatch, shimazu+worker_chromium.org, kinuko+worker_chromium.org, dglazkov+blink, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary SafePointScope Now that the per-thread heap is working, we don't need to have a SafePointScope that had been used to give a chance to a GCing thread to stop this thread. BUG=671856 Review-Url: https://codereview.chromium.org/2688383003 Cr-Commit-Position: refs/heads/master@{#449917} Committed: https://chromium.googlesource.com/chromium/src/+/58532772e54feeec7258d42731695f7d183293b8

Patch Set 1 #

Total comments: 1

Patch Set 2 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -45 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystem.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/WaitableEvent.cpp View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebHeap.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebHeap.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-13 01:48:19 UTC) #2
sof
lgtm https://codereview.chromium.org/2688383003/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.cpp File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right): https://codereview.chromium.org/2688383003/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.cpp#newcode228 third_party/WebKit/Source/core/workers/WorkerThread.cpp:228: { nit^2: drop the variable scope.
3 years, 10 months ago (2017-02-13 06:29:02 UTC) #5
haraken
> https://codereview.chromium.org/2688383003/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.cpp > File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right): > > https://codereview.chromium.org/2688383003/diff/1/third_party/WebKit/Source/core/workers/WorkerThread.cpp#newcode228 > third_party/WebKit/Source/core/workers/WorkerThread.cpp:228: { > nit^2: drop ...
3 years, 10 months ago (2017-02-13 06:31:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688383003/20001
3 years, 10 months ago (2017-02-13 06:32:02 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 08:02:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/58532772e54feeec7258d4273169...

Powered by Google App Engine
This is Rietveld 408576698