third_party/WebKit/Source/web/WebHeap.cpp - Issue 2688383003: Remove unnecessary SafePointScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebHeap.cpp

Issue 2688383003: Remove unnecessary SafePointScope (Closed)

Patch Set: temp Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebHeap.cpp

diff --git a/third_party/WebKit/Source/web/WebHeap.cpp b/third_party/WebKit/Source/web/WebHeap.cpp

index 151dadc337a0771075a823f5664b7417f10a54f9..99925fe017100aa106cabda6dc471691d9fb62af 100644

--- a/third_party/WebKit/Source/web/WebHeap.cpp

+++ b/third_party/WebKit/Source/web/WebHeap.cpp

@@ -34,15 +34,6 @@

namespace blink {

-WebHeap::SafePointScope::SafePointScope() {

- CHECK(!ThreadState::current()->isAtSafePoint());

- ThreadState::current()->enterSafePoint(BlinkGC::HeapPointersOnStack, this);

-WebHeap::SafePointScope::~SafePointScope() {

- ThreadState::current()->leaveSafePoint();

void WebHeap::collectGarbageForTesting() {

ThreadState::current()->collectGarbage(

BlinkGC::HeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);