third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp - Issue 2688383003: Remove unnecessary SafePointScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

Issue 2688383003: Remove unnecessary SafePointScope (Closed)

Patch Set: temp Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteFileSystem.cpp ('k') | third_party/WebKit/Source/platform/WaitableEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

diff --git a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

index b2ad12057b2fc7cd190b568d105ad60cd932aeb0..251daa09566d16b9d0b2ae193962f3cfa92f2cee 100644

--- a/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

+++ b/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp

@@ -102,8 +102,6 @@ int SQLiteStatement::prepare() {

*statement = nullptr;

int error;

{

- SafePointScope scope(BlinkGC::HeapPointersOnStack);

SQL_DVLOG(1) << "SQL - prepare - " << query.data();

// Pass the length of the string including the null character to

@@ -130,9 +128,6 @@ int SQLiteStatement::prepare() {

}

int SQLiteStatement::step() {

- SafePointScope scope(BlinkGC::HeapPointersOnStack);

- // ASSERT(m_isPrepared);

if (!m_statement)

return SQLITE_OK;