Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

This is a follow-up to http://crrev.com/2686523003 to make it slightly
simpler; I just noticed that there's already a method for checking
whether a path in the layout tests directory is a directory.

BUG=689642
Review-Url: https://codereview.chromium.org/2687683003
Cr-Commit-Position: refs/heads/master@{#449079}
Committed: https://chromium.googlesource.com/chromium/src/+/5d73b79a7aff119e64e33a53762910cb40e6d1cc

[qyearsley, 2017-02-08 18:30:01]

Description was changed from

==========
In RemoveFlakesOMatic, use Port.test_isdir

This is a follow-up to http://crrev.com/2686523003 to make it slightly
simpler; I just noticed that there's already a method for checking
whether a path in the layout tests directory is a directory.

BUG=689642
==========

to

==========
Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

This is a follow-up to http://crrev.com/2686523003 to make it slightly
simpler; I just noticed that there's already a method for checking
whether a path in the layout tests directory is a directory.

BUG=689642
==========

[qyearsley, 2017-02-08 18:30:02]

qyearsley@chromium.org changed reviewers:
+ bokan@chromium.org

[qyearsley, 2017-02-08 18:30:02]

Description was changed from

==========
In RemoveFlakesOMatic, use Port.test_isdir

This is a follow-up to http://crrev.com/2686523003 to make it slightly
simpler; I just noticed that there's already a method for checking
whether a path in the layout tests directory is a directory.

BUG=689642
==========

to

==========
Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

This is a follow-up to http://crrev.com/2686523003 to make it slightly
simpler; I just noticed that there's already a method for checking
whether a path in the layout tests directory is a directory.

BUG=689642
==========

[qyearsley, 2017-02-08 18:30:02]

qyearsley@chromium.org changed reviewers:
+ bokan@chromium.org

[qyearsley, 2017-02-08 18:30:56]

https://codereview.chromium.org/2687683003/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
(left):

https://codereview.chromium.org/2687683003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py:109:
if self._is_directory(test_expectation_line.path):
I'm not really sure whether it matters whether test_expectation_line.path or
test_expectation_line.name is used; I suspect in most cases it doesn't matter,
but there's probably an edge case where it does.

[bokan, 2017-02-08 19:12:01]

lgtm

https://codereview.chromium.org/2687683003/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
(left):

https://codereview.chromium.org/2687683003/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py:109:
if self._is_directory(test_expectation_line.path):
On 2017/02/08 18:30:56, qyearsley wrote:
> I'm not really sure whether it matters whether test_expectation_line.path or
> test_expectation_line.name is used; I suspect in most cases it doesn't matter,
> but there's probably an edge case where it does.

Looks to me like the only difference is that path is "normalized" using this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...

I don't think it makes a difference in our case, either looks good to me.

[qyearsley, 2017-02-08 19:14:27]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-02-08 19:15:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 20:27:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486581267231090, "parent_rev":
"edd7a29d3ba0969a5a3ae52c1e18a79d6cda8dd1", "commit_rev":
"5d73b79a7aff119e64e33a53762910cb40e6d1cc"}

[commit-bot: I haz the power, 2017-02-08 20:28:26]

Description was changed from

==========
Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

This is a follow-up to http://crrev.com/2686523003 to make it slightly
simpler; I just noticed that there's already a method for checking
whether a path in the layout tests directory is a directory.

BUG=689642
==========

to

==========
Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

This is a follow-up to http://crrev.com/2686523003 to make it slightly
simpler; I just noticed that there's already a method for checking
whether a path in the layout tests directory is a directory.

BUG=689642

Review-Url: https://codereview.chromium.org/2687683003
Cr-Commit-Position: refs/heads/master@{#449079}
Committed:
https://chromium.googlesource.com/chromium/src/+/5d73b79a7aff119e64e33a537629...
==========

[commit-bot: I haz the power, 2017-02-08 20:28:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d73b79a7aff119e64e33a537629...