Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Updates TestExpectations based on results in builder bots.
 
 Scans the TestExpectations file and uses results from actual builder bots runs
 to remove tests that are marked as flaky but don't fail in the specified way.
 
 E.g. If a test has this expectation:
@@ skipping 88 matching lines @@
         # Don't check lines that have expectations like NeedsRebaseline or Skip.
         if self._has_unstrippable_expectations(expectations):
             return False
 
         # Don't check lines unless they're flaky. i.e. At least one expectation is a PASS.
         if not self._has_pass_expectation(expectations):
             return False
 
         # Don't check lines that have expectations for directories, since
         # the flakiness of all sub-tests isn't as easy to check.
-        if self._is_directory(test_expectation_line.path):

[qyearsley, 2017/02/08 18:30:56]

I'm not really sure whether it matters whether test_expectation_line.path or
test_expectation_line.name is used; I suspect in most cases it doesn't matter,
but there's probably an edge case where it does.

[bokan, 2017/02/08 19:12:01]

Looks to me like the only difference is that path is "normalized" using this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...

I don't think it makes a difference in our case, either looks good to me.

+        if self._port.test_isdir(test_expectation_line.name):
             return False
 
         # The line can be deleted if the only expectation on the line that appears in the actual
         # results is the PASS expectation.
         builders_checked = []
         for config in test_expectation_line.matching_configurations:
             builder_name = self._host.builders.builder_name_for_specifiers(config.version, config.build_type)
 
             if not builder_name:
                 _log.debug('No builder with config %s', config)
@@ skipping 69 matching lines @@
 
         Returns:
             True if at least one of the expectations is unstrippable. False
             otherwise.
         """
         unstrippable_expectations = ('REBASELINE', 'NEEDSREBASELINE',
                                      'NEEDSMANUALREBASELINE', 'SLOW',
                                      'SKIP')
         return any(s in expectations for s in unstrippable_expectations)
 
-    def _is_directory(self, path):
-        """Checks whether a path relative to the layout tests directory is a directory."""
-        filesystem = self._host.filesystem
-        abs_path = filesystem.join(self._port.layout_tests_dir(), path)
-        return filesystem.isdir(abs_path)
-
     def _get_builder_results_by_path(self):
         """Returns a dictionary of results for each builder.
 
         Returns a dictionary where each key is a builder and value is a dictionary containing
         the distinct results for each test. E.g.
 
         {
             'WebKit Linux Precise': {
                   'test1.html': ['PASS', 'IMAGE'],
                   'test2.html': ['PASS'],
@@ skipping 126 matching lines @@
         """Writes the given TestExpectations object to the filesystem.
 
         Args:
             test_expectations: The TestExpectations object to write.
             test_expectations_file: The full file path of the Blink
                 TestExpectations file. This file will be overwritten.
         """
         self._host.filesystem.write_text_file(
             test_expectations_file,
             TestExpectations.list_to_string(test_expectations, reconstitute_only_these=[]))