Refactoring: In RemoveFlakesOMatic, use Port.test_isdir.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
index 132b8bd1627dff7c43ad038bea79f3c7c335276d..5c32387b4ec77faf197ecca28372ff2657c7f553 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations.py
@@ -106,7 +106,7 @@ class RemoveFlakesOMatic(object):
 
         # Don't check lines that have expectations for directories, since
         # the flakiness of all sub-tests isn't as easy to check.
-        if self._is_directory(test_expectation_line.path):

[qyearsley, 2017/02/08 18:30:56]

I'm not really sure whether it matters whether test_expectation_line.path or
test_expectation_line.name is used; I suspect in most cases it doesn't matter,
but there's probably an edge case where it does.

[bokan, 2017/02/08 19:12:01]

Looks to me like the only difference is that path is "normalized" using this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...

I don't think it makes a difference in our case, either looks good to me.

+        if self._port.test_isdir(test_expectation_line.name):
             return False
 
         # The line can be deleted if the only expectation on the line that appears in the actual
@@ -196,12 +196,6 @@ class RemoveFlakesOMatic(object):
                                      'SKIP')
         return any(s in expectations for s in unstrippable_expectations)
 
-    def _is_directory(self, path):
-        """Checks whether a path relative to the layout tests directory is a directory."""
-        filesystem = self._host.filesystem
-        abs_path = filesystem.join(self._port.layout_tests_dir(), path)
-        return filesystem.isdir(abs_path)
-
     def _get_builder_results_by_path(self):
         """Returns a dictionary of results for each builder.