cc: Remove more uniform location caching

cc: Remove more uniform location caching

Because we know the cc::Program that is bound, we can just specify the
values we want to set, and look up the uniform locations from the bound
program.

Also, merge lots of redundant code into SetShader* functions.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687653002
Cr-Commit-Position: refs/heads/master@{#449121}
Committed: https://chromium.googlesource.com/chromium/src/+/80f3afb13a970dc64b835ce91f3f1c16466c836d

[ccameron, 2017-02-08 09:33:49]

Description was changed from

==========
cc: Remove more uniform location caching

Because we know the cc::Program that is bound, we can just specify the
values we want to set, and look up the uniform locations from the bound
program.

Also, merge lots of redundant code into SetShader* functions.

BUG=667966
==========

to

==========
cc: Remove more uniform location caching

Because we know the cc::Program that is bound, we can just specify the
values we want to set, and look up the uniform locations from the bound
program.

Also, merge lots of redundant code into SetShader* functions.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-02-08 09:33:52]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 09:34:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-02-08 09:56:07]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-02-08 09:56:08]

The main point of this was to get TexturedQuadDrawCache to hold Program* (so
that I can set color state on it), but then I noticed a bunch of uniform caching
and passing and couldn't help myself.

[ccameron, 2017-02-08 10:03:53]

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2580: void GLRenderer::SetShaderOpacity(const DrawQuad*
quad) {
lmk if this stateful way of reading |program_shadow_| feels not-good to you. If
so, I can change to passing in a Program*

[commit-bot: I haz the power, 2017-02-08 11:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 11:36:28]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[enne (OOO), 2017-02-08 19:14:37]

lgtm

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.cc#ne...
cc/output/gl_renderer.cc:2580: void GLRenderer::SetShaderOpacity(const DrawQuad*
quad) {
On 2017/02/08 at 10:03:53, ccameron wrote:
> lmk if this stateful way of reading |program_shadow_| feels not-good to you.
If so, I can change to passing in a Program*

I think this is fine.

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.h
File cc/output/gl_renderer.h (right):

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.h#new...
cc/output/gl_renderer.h:300: unsigned offscreen_framebuffer_id_ = 0;
Windows probably wants to s/0/0u/ this

[enne (OOO), 2017-02-08 19:14:53]

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.h
File cc/output/gl_renderer.h (right):

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.h#new...
cc/output/gl_renderer.h:300: unsigned offscreen_framebuffer_id_ = 0;
On 2017/02/08 at 19:14:37, enne wrote:
> Windows probably wants to s/0/0u/ this

Oh apparently not! Huh.

[ccameron, 2017-02-08 21:03:53]

Thanks!

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.h
File cc/output/gl_renderer.h (right):

https://codereview.chromium.org/2687653002/diff/1/cc/output/gl_renderer.h#new...
cc/output/gl_renderer.h:300: unsigned offscreen_framebuffer_id_ = 0;
On 2017/02/08 19:14:52, enne wrote:
> On 2017/02/08 at 19:14:37, enne wrote:
> > Windows probably wants to s/0/0u/ this
> 
> Oh apparently not! Huh.

Eh, did it anyway.

[ccameron, 2017-02-08 21:03:56]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-02-08 21:03:56]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2687653002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2017-02-08 21:04:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 22:53:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486587836232830,
"parent_rev": "d5c9128c3d52b14e61e82279963348fdf0b07a83", "commit_rev":
"80f3afb13a970dc64b835ce91f3f1c16466c836d"}

[commit-bot: I haz the power, 2017-02-08 22:54:32]

Description was changed from

==========
cc: Remove more uniform location caching

Because we know the cc::Program that is bound, we can just specify the
values we want to set, and look up the uniform locations from the bound
program.

Also, merge lots of redundant code into SetShader* functions.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Remove more uniform location caching

Because we know the cc::Program that is bound, we can just specify the
values we want to set, and look up the uniform locations from the bound
program.

Also, merge lots of redundant code into SetShader* functions.

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687653002
Cr-Commit-Position: refs/heads/master@{#449121}
Committed:
https://chromium.googlesource.com/chromium/src/+/80f3afb13a970dc64b835ce91f3f...
==========

[commit-bot: I haz the power, 2017-02-08 22:54:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80f3afb13a970dc64b835ce91f3f...