Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: cc/output/gl_renderer_unittest.cc

Issue 2687653002: cc: Remove more uniform location caching (Closed)
Patch Set: Review feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/gl_renderer_draw_cache.cc ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer_unittest.cc
diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc
index 3611a5915e3f56bfa34342e31966b5b49ce77e70..42cdb4fcf95bb771c530c8992bc2c5af92406df1 100644
--- a/cc/output/gl_renderer_unittest.cc
+++ b/cc/output/gl_renderer_unittest.cc
@@ -410,7 +410,7 @@ class GLRendererShaderTest : public GLRendererTest {
ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, NO_AA,
NO_MASK, false, false));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestRenderPassColorMatrixProgram(TexCoordPrecision precision,
@@ -419,7 +419,7 @@ class GLRendererShaderTest : public GLRendererTest {
ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, NO_AA,
NO_MASK, false, true));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestRenderPassMaskProgram(TexCoordPrecision precision,
@@ -429,7 +429,7 @@ class GLRendererShaderTest : public GLRendererTest {
renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
precision, sampler, blend_mode, NO_AA, HAS_MASK, false, false));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestRenderPassMaskColorMatrixProgram(TexCoordPrecision precision,
@@ -439,7 +439,7 @@ class GLRendererShaderTest : public GLRendererTest {
renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
precision, sampler, blend_mode, NO_AA, HAS_MASK, false, true));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestRenderPassProgramAA(TexCoordPrecision precision,
@@ -448,7 +448,7 @@ class GLRendererShaderTest : public GLRendererTest {
ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, USE_AA,
NO_MASK, false, false));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestRenderPassColorMatrixProgramAA(TexCoordPrecision precision,
@@ -457,7 +457,7 @@ class GLRendererShaderTest : public GLRendererTest {
ProgramKey::RenderPass(precision, SAMPLER_TYPE_2D, blend_mode, USE_AA,
NO_MASK, false, true));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestRenderPassMaskProgramAA(TexCoordPrecision precision,
@@ -467,7 +467,7 @@ class GLRendererShaderTest : public GLRendererTest {
renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
precision, sampler, blend_mode, USE_AA, HAS_MASK, false, false));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestRenderPassMaskColorMatrixProgramAA(TexCoordPrecision precision,
@@ -477,14 +477,14 @@ class GLRendererShaderTest : public GLRendererTest {
renderer_->GetProgramIfInitialized(ProgramKey::RenderPass(
precision, sampler, blend_mode, USE_AA, HAS_MASK, false, true));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
void TestSolidColorProgramAA() {
const Program* program =
renderer_->GetProgramIfInitialized(ProgramKey::SolidColor(USE_AA));
EXPECT_PROGRAM_VALID(program);
- EXPECT_EQ(program->program(), renderer_->program_shadow_);
+ EXPECT_EQ(program, renderer_->program_shadow_);
}
RendererSettings settings_;
« no previous file with comments | « cc/output/gl_renderer_draw_cache.cc ('k') | third_party/WebKit/LayoutTests/TestExpectations » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698